RE: [EXT] Re: [PATCH v5] arm64: dts: ls1088a: add one more thermal zone node
From: Andy Tang
Date: Fri Apr 12 2019 - 03:48:09 EST
> -----Original Message-----
> From: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
> Sent: 2019å4æ12æ 3:15
> To: Andy Tang <andy.tang@xxxxxxx>; shawnguo@xxxxxxxxxx
> Cc: Leo Li <leoyang.li@xxxxxxx>; robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx;
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; rui.zhang@xxxxxxxxx;
> edubezval@xxxxxxxxx
> Subject: [EXT] Re: [PATCH v5] arm64: dts: ls1088a: add one more thermal zone
> node
>
> WARNING: This email was created outside of NXP. DO NOT CLICK links or
> attachments unless you recognize the sender and know the content is safe.
>
>
>
> On 11/04/2019 10:32, Yuantian Tang wrote:
> > Ls1088a has 2 thermal sensors, core cluster and SoC platform. Core
> > cluster sensor is used to monitor the temperature of core and SoC
> > platform is for platform. The current dts only support the first sensor.
> > This patch adds the second sensor node to dts to enable it.
> >
> > Signed-off-by: Yuantian Tang <andy.tang@xxxxxxx>
> > ---
> > v5:
> > - update the thermal zone name due to the length limitation
> > - remove cooling map in platform zone
> > v4:
> > - use hyphen instead of underscore in node name
> > v3:
> > - use more descriptive name for each zone
> > v2:
> > - Add more information about sensors to description
> > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 28
> ++++++++++++++++++++---
> > 1 files changed, 24 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index de93b42..de39672 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -129,19 +129,19 @@
> > };
> >
> > thermal-zones {
> > - cpu_thermal: cpu-thermal {
> > + core-cluster {
> > polling-delay-passive = <1000>;
> > polling-delay = <5000>;
> > thermal-sensors = <&tmu 0>;
> >
> > trips {
> > - cpu_alert: cpu-alert {
> > + core_cluster_alert: core-cluster-alert {
> > temperature = <85000>;
> > hysteresis = <2000>;
> > type = "passive";
> > };
> >
> > - cpu_crit: cpu-crit {
> > + core_cluster_crit: core-cluster-crit {
> > temperature = <95000>;
> > hysteresis = <2000>;
> > type = "critical"; @@ -150,7
> > +150,7 @@
> >
> > cooling-maps {
> > map0 {
> > - trip = <&cpu_alert>;
> > + trip = <&core_cluster_alert>;
> > cooling-device =
> > <&cpu0
> THERMAL_NO_LIMIT THERMAL_NO_LIMIT>,
> > <&cpu1
> THERMAL_NO_LIMIT
> > THERMAL_NO_LIMIT>, @@ -163,6 +163,26 @@
> > };
> > };
> > };
> > +
> > + platform {
> > + polling-delay-passive = <1000>;
> > + polling-delay = <5000>;
> > + thermal-sensors = <&tmu 1>;
> > +
> > + trips {
> > + platform-alert {
> > + temperature = <85000>;
> > + hysteresis = <2000>;
> > + type = "passive";
> > + };
> > +
> > + platform-crit {
> > + temperature = <95000>;
> > + hysteresis = <2000>;
> > + type = "critical";
> > + };
> > + };
> > + };
>
>
> Unfortunately, the documentation says the thermal zone node must contain a
> "cooling-maps" entry.
That's a question.
If I add "cooling-maps", then multiple zones will use same cooling device.
If I don't, documentation says it is a " Required properties".
I am wondering how it was dealt with on other platform supporting multiple zones.
Hi Shawn,
What's your opinions about this?
BR,
Andy
>
> It makes sense as if there is no cooling device, there is no action to be taken
> thus polling the temperature just add noise to the system.
>
>
>
> > };
> >
> > timer {
> >
>
>
> --
>
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin
> aro.org%2F&data=02%7C01%7Candy.tang%40nxp.com%7Cda3cde05ae944
> d7fdb5508d6beb1f69a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C
> 636906068893110033&sdata=2KAlALDq3%2FR0W5jGf1E4DR1GHTEpyO2w
> YwIXZT7ZS8E%3D&reserved=0> Linaro.org â Open source software for
> ARM SoCs
>
> Follow Linaro:
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.fac
> ebook.com%2Fpages%2FLinaro&data=02%7C01%7Candy.tang%40nxp.com
> %7Cda3cde05ae944d7fdb5508d6beb1f69a%7C686ea1d3bc2b4c6fa92cd99c5c30
> 1635%7C0%7C0%7C636906068893110033&sdata=2aINIFXnw6nNehmU5xK
> SgpeekA7Pv6YJVVB7gA5FxYU%3D&reserved=0> Facebook |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter.c
> om%2F%23!%2Flinaroorg&data=02%7C01%7Candy.tang%40nxp.com%7Cd
> a3cde05ae944d7fdb5508d6beb1f69a%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636906068893110033&sdata=X6eDvdATzokwP7VVKx02yge
> 6Akebd89%2BWRsYRE5rgf8%3D&reserved=0> Twitter |
> <https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.lin
> aro.org%2Flinaro-blog%2F&data=02%7C01%7Candy.tang%40nxp.com%7C
> da3cde05ae944d7fdb5508d6beb1f69a%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C636906068893110033&sdata=0F6G6GKdBDQAWZ50OjVcvt
> 1cvksBlk1jLngW1m4mDEw%3D&reserved=0> Blog