Re: [PATCH v3 06/11] PCI: imx6: Make use of BIT() in constant definitions

[Lucas Stach]

Am Sonntag, den 31.03.2019, 21:25 -0700 schrieb Andrey Smirnov:
> Avoid using explicit left shifts and convert various definitions to
> use BIT() instead. No functional change intended.
> 
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx>
> > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> > Cc: Fabio Estevam <fabio.estevam@xxxxxxx>
> > Cc: Chris Healy <cphealy@xxxxxxxxx>
> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > Cc: Leonard Crestez <leonard.crestez@xxxxxxx>
> > Cc: "A.s. Dong" <aisheng.dong@xxxxxxx>
> > Cc: Richard Zhu <hongxing.zhu@xxxxxxx>
> Cc: linux-imx@xxxxxxx
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-pci@xxxxxxxxxxxxxxx
> Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx>

Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

> ---
> Âdrivers/pci/controller/dwc/pci-imx6.c | 8 ++++----
> Â1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index bb95a3273ca2..b1f30b94fb30 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -118,14 +118,14 @@ struct imx6_pcie {
> Â
> Â/* PHY registers (not memory-mapped) */
> > Â#define PCIE_PHY_ATEOVRD			0x10
> > -#defineÂÂPCIE_PHY_ATEOVRD_EN			(0x1 << 2)
> > +#defineÂÂPCIE_PHY_ATEOVRD_EN			BIT(2)
> > Â#defineÂÂPCIE_PHY_ATEOVRD_REF_CLKDIV_SHIFT	0
> > Â#defineÂÂPCIE_PHY_ATEOVRD_REF_CLKDIV_MASK	0x1
> Â
> > Â#define PCIE_PHY_MPLL_OVRD_IN_LO		0x11
> > Â#defineÂÂPCIE_PHY_MPLL_MULTIPLIER_SHIFT		2
> > Â#defineÂÂPCIE_PHY_MPLL_MULTIPLIER_MASK		0x7f
> > -#defineÂÂPCIE_PHY_MPLL_MULTIPLIER_OVRD		(0x1 << 9)
> > +#defineÂÂPCIE_PHY_MPLL_MULTIPLIER_OVRD		BIT(9)
> Â
> Â#define PCIE_PHY_RX_ASIC_OUT 0x100D
> > Â#define PCIE_PHY_RX_ASIC_OUT_VALID	(1 << 0)
> @@ -148,8 +148,8 @@ struct imx6_pcie {
> > Â#define PCIE_PHY_CMN_REG26_ATT_MODE	0xBC
> Â
> Â#define PHY_RX_OVRD_IN_LO 0x1005
> -#define PHY_RX_OVRD_IN_LO_RX_DATA_EN (1 << 5)
> -#define PHY_RX_OVRD_IN_LO_RX_PLL_EN (1 << 3)
> > +#define PHY_RX_OVRD_IN_LO_RX_DATA_EN		BIT(5)
> > +#define PHY_RX_OVRD_IN_LO_RX_PLL_EN		BIT(3)
> Â
> Âstatic int pcie_phy_poll_ack(struct imx6_pcie *imx6_pcie, int exp_val)
> Â{