Re: [PATCH 1/3] RISC-V: Add separate asm/encoding.h for spec related defines

From: Christoph Hellwig
Date: Sat Apr 13 2019 - 03:54:02 EST


On Sat, Apr 13, 2019 at 07:39:35AM +0000, Anup Patel wrote:
> It's better to have all RISC-V spec related defines in one place
> so this patch adds separate asm/encoding.h for such defines which
> can be included in assembly as well as C code.

<asm/csr.h> can be included from assembly just fine already.
and we already do that. So I don't really see much of a point
in splitting it.