RE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices

From: Jose Abreu
Date: Tue Apr 16 2019 - 04:01:27 EST


From: Leonidas P. Papadakos <papadakospan@xxxxxxxxx>
Date: Mon, Apr 15, 2019 at 23:19:19

>
> So far with iperf testing
>
> txpbl <0x20>
> and no-pbl-x8 gives me the best tx I've seen so far:
> 914 average, peak 933 Mbps

Cool. If you want to do more tests then the next step is to remove the
no-pbl-x8 and start with pbl = 0x1, then 0x2, 0x4, 0x8, 0x10, 0x20.
Without the pblx8 binding then PBL setting will be multiplied by 8.

Do not try to use PBL values different than the above because it can lead
to undefined behavior.

Anyway, I think the performance values you presented are good.

Thanks,
Jose Miguel Abreu