Re: [PATCH 4/4] locking/lockdep: Test all incompatible scenario at once in check_irq_usage()

From: Frederic Weisbecker
Date: Tue Apr 16 2019 - 11:21:12 EST


On Tue, Apr 16, 2019 at 01:20:09PM +0200, Peter Zijlstra wrote:
> On Sat, Apr 13, 2019 at 02:35:45AM +0200, Frederic Weisbecker wrote:
> > On Thu, Apr 11, 2019 at 12:46:32PM +0200, Peter Zijlstra wrote:
> > Same here:
> >
> > As above, we clear bitnr0 (LOCK_*_READ off) with bitmask ops. First, for all bits
> > with bitnr1 set (LOCK_ENABLED_*) , add those with bitnr1 cleared (LOCK_USED_IN_*).
> > And then mask out all bitnr1.
>
> Ha! you failed to spot my failure, all the above should be bitnr0 of
> course :/

Ooops, right.

> Find updated below.

Very good now, thanks a lot!