Re: [PATCH net-next] net: phy: micrel: add Asym Pause workaround

From: Andrew Lunn
Date: Tue Apr 16 2019 - 12:39:30 EST


On Tue, Apr 16, 2019 at 12:10:20PM +0200, Antoine Tenart wrote:
> The Micrel KSZ9031 PHY may fail to establish a link when the Asymmetric
> Pause capability is set. This issue is described in a Silicon Errata
> (DS80000691D or DS80000692D), which advises to always disable the
> capability. This patch implements the workaround by defining a KSZ9031
> specific get_feature callback to force the Asymmetric Pause capability
> bit to be cleared.
>
> This fixes issues where the link would not come up at boot time, or when
> the Asym Pause bit was set later on.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew