Re: [PATCH v3 2/9] kbuild: Support for Symbols.list creation
From: Miroslav Benes
Date: Tue Apr 16 2019 - 15:03:00 EST
On Tue, 16 Apr 2019, Joe Lawrence wrote:
> On 4/11/19 3:04 PM, Miroslav Benes wrote:
> >> diff --git a/samples/livepatch/Makefile b/samples/livepatch/Makefile
> >> index 2472ce39a18d..8b9b42a258ad 100644
> >> --- a/samples/livepatch/Makefile
> >> +++ b/samples/livepatch/Makefile
> >> @@ -1,3 +1,4 @@
> >> +LIVEPATCH_livepatch-sample := y
> >> obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-sample.o
> >> obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-mod.o
> >> obj-$(CONFIG_SAMPLE_LIVEPATCH) += livepatch-shadow-fix1.o
> > We discussed this and I think there has been no conclusion yet. Shouldn't
> > we do the same (add LIVEPATCH_) for the other samples here as well?
> In v2 review, I mentioned moving this hunk to ("modpost: Add modinfo flag to
> livepatch modules") along with the same change to the other sample modules. I
> didn't apply that for v3, but can do so for the next spin if it makes the
> commits easier to review.
I think it belongs here, but I may be missing something. Anyway, it is not
really important, so I'd leave it up to you.