Re: [PATCH v2] x86/PCI: fix a memory leak bug
From: Thomas Gleixner
Date: Tue Apr 16 2019 - 15:58:44 EST
On Tue, 16 Apr 2019, Wenwen Wang wrote:
> In pcibios_irq_init(), the PCI IRQ routing table 'pirq_table' is firstly
> found through pirq_find_routing_table(). If the table is not found and
> 'CONFIG_PCI_BIOS' is defined, the table is then allocated in
> pcibios_get_irq_routing_table() using kmalloc(). In the following
> execution, if the I/O APIC is used, this table is actually not used.
> However, in that case, the allocated table is not freed, which can lead to
> a memory leak bug.
s/which can lead to/which is/
There is no 'can'. It simply is a memory leak.
> To fix this issue, this patch frees the allocated table if it is not used.
To fix this issue, free the allocated table if it is not used.
'this patch' is completely redundant information and discouraged in
Other than that:
Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>