Re: [PATCH v5 1/4] dt-bindings: arm: coresight: Add new compatible for static replicator

From: Mathieu Poirier
Date: Tue Apr 16 2019 - 16:18:55 EST


Hi Leo,

On Fri, 12 Apr 2019 at 04:28, Leo Yan <leo.yan@xxxxxxxxxx> wrote:
>
> CoreSight uses below bindings for replicator:
>
> Dynamic replicator, aka. configurable replicator:
> "arm,coresight-dynamic-replicator", "arm,primecell";
>
> Static replicator, aka. non-configurable replicator:
> "arm,coresight-replicator";
>
> The compatible string "arm,coresight-replicator" is not an explicit
> naming to express the replicator is 'static'. To unify the naming
> convention, this patch introduces a new compatible string
> "arm,coresight-static-replicator" for the static replicator; the
> compatible string "arm,coresight-replicator" is kept for backward
> compatibility, but tag it as obsolete and suggest to use the new
> compatible string.
>
> As result CoreSight replicator have below bindings:
>
> Dynamic replicator:
> "arm,coresight-dynamic-replicator", "arm,primecell";
>
> Static replicator:
> "arm,coresight-static-replicator";
> "arm,coresight-replicator"; (obsolete)
>
> Signed-off-by: Leo Yan <leo.yan@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/arm/coresight.txt | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt
> index f8aff65ab921..d02d160fa8ac 100644
> --- a/Documentation/devicetree/bindings/arm/coresight.txt
> +++ b/Documentation/devicetree/bindings/arm/coresight.txt
> @@ -69,7 +69,10 @@ its hardware characteristcs.
>
> * compatible: Currently supported value is (note the absence of the
> AMBA markee):
> - - "arm,coresight-replicator"
> + - Coresight Non-configurable Replicator:
> + "arm,coresight-static-replicator";
> + "arm,coresight-replicator"; (OBSOLETE. For backward
> + compatibility and will be removed)
>
> * port or ports: see "Graph bindings for Coresight" below.
>
> @@ -169,7 +172,7 @@ Example:
> /* non-configurable replicators don't show up on the
> * AMBA bus. As such no need to add "arm,primecell".
> */
> - compatible = "arm,coresight-replicator";
> + compatible = "arm,coresight-static-replicator";
>
> out-ports {
> #address-cells = <1>;
> --
> 2.17.1

Since this is a binding patch it needs to be sent on its own.

>