Re: [PATCH v2] module: add stubs for within_module functions

From: Jessica Yu
Date: Wed Apr 17 2019 - 05:00:00 EST


+++ Andrew Morton [16/04/19 14:38 -0700]:
On Tue, 16 Apr 2019 11:56:21 -0700 Tri Vo <trong@xxxxxxxxxxx> wrote:

On Tue, Apr 16, 2019 at 10:55 AM Tri Vo <trong@xxxxxxxxxxx> wrote:
>
> On Tue, Apr 16, 2019 at 8:21 AM Jessica Yu <jeyu@xxxxxxxxxx> wrote:
> >
> > +++ Tri Vo [15/04/19 11:18 -0700]:
> > >Provide stubs for within_module_core(), within_module_init(), and
> > >within_module() to prevent build errors when !CONFIG_MODULES.
> > >
> > >v2:
> > >- Generalized commit message, as per Jessica.
> > >- Stubs for within_module_core() and within_module_init(), as per Nick.
> > >
> > >Suggested-by: Matthew Wilcox <willy@xxxxxxxxxxxxx>
> > >Reported-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> > >Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> > >Link: https://marc.info/?l=linux-mm&m=155384681109231&w=2
> > >Signed-off-by: Tri Vo <trong@xxxxxxxxxxx>
> >
> > Applied, thanks!
>
> Thank you!

Andrew,
this patch fixes 8c3d220cb6b5 ("gcov: clang support"). Could you
re-apply the gcov patch? Sorry, if it's a dumb question. I'm not
familiar with how cross-tree patches are handled in Linux.

hm, I wonder what Jessica applied this patch to?

I applied the patch that supplies the missing within_module() stubs to
the modules-next branch (a link to the repo is available in
MAINTAINERS), it's landed in linux-next by now, and it should fix the
build error reported by the kbuild test bot.

Thanks,

Jessica