Re: [RFC PATCH v4 4/4] x86/acrn: Add hypercall for ACRN guest

From: Borislav Petkov
Date: Thu Apr 18 2019 - 06:11:40 EST

On Mon, Apr 15, 2019 at 10:00:57AM +0800, Zhao Yakui wrote:
> When ACRN hypervisor is detected, the hypercall is needed so that the
> ACRN guest can query/config some settings. For example: it can be used
> to query the resources in hypervisor and manage the CPU/memory/device/
> interrupt for guest operating system.
> Add the hypercall so that the kernel can communicate with the low-level
> ACRN hypervisor. It is implemented with vmacll instruction.

This still has unfixed stuff from 2 review cycles ago.

Thomas corrected this in his review to:

"is implemented with the VMCALL instruction"

You ignored it.

I reminded you about it and suggested to check and incorporate *all*
review feedback before sending another version:

You ignored it again.

Now, if you get ignored, you know why, right?


Good mailing practices for 400: avoid top-posting and trim the reply.