Re: [PATCH V2 3/3] regulator: slg51000: add slg51000 regulator driver

From: Mark Brown
Date: Thu Apr 18 2019 - 06:16:13 EST


On Thu, Apr 18, 2019 at 03:09:44PM +0900, Eric Jeong wrote:

> I updated regulator_ops structure to use use the helper function
> which is regulator_is_enabled_regmap() instead reading status bits
> for is_enabled() operation.

> v2: use regulator helper function for is_enabled()

There's also the get_status() operation which you should be able to
implement using the status bits you were reading before - that lets
the framework know if the regualtor is actually working which can help
with error handling so it's good to do.

Attachment: signature.asc
Description: PGP signature