Re: [PATCH] stmmac: pci: Adjust IOT2000 matching

From: Jan Kiszka
Date: Thu Apr 18 2019 - 14:24:48 EST

On 18.04.19 19:43, David Miller wrote:
From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
Date: Thu, 18 Apr 2019 11:14:56 +0200

@@ -170,8 +176,6 @@ static const struct dmi_system_id quark_pci_dmi[] = {
.matches = {
- "6ES7647-0AA00-1YA2"),
.driver_data = (void *)&iot2040_stmmac_dmi_data,

So really, every IOT2000 that doesn't have the IOT2020 asset tag will be
a 2040? Forever?

Yes, seriously. The next version won't have all that DMI and ACPI stuff. And if there will ever be a version with that again, it will not be labeled "IOT2000" via the board name entry. And it will have more robust hardware discovery as well. Lesson(s) learned, in fact not only for this product series.


Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux