Re: [PATCH] RAS/CEC: Add debugfs switch to disable at run time
From: Cong Wang
Date: Sat Apr 20 2019 - 01:51:05 EST
On Thu, Apr 18, 2019 at 5:07 PM Luck, Tony <tony.luck@xxxxxxxxx> wrote:
> On Fri, Apr 19, 2019 at 01:29:10AM +0200, Borislav Petkov wrote:
> > Which reminds me, Tony, I think all those debugging files "pfn"
> > and "array" and the one you add now, should all be under a
> > CONFIG_RAS_CEC_DEBUG which is default off and used only for development.
> > Mind adding that too pls?
> Patch below, on top of previous patch. Note that I didn't move "enable"
> into the RAS_CEC_DEBUG code. I think it has some value even on
> production systems. It is still in debugfs (which many production
> systems don't mount) so I don't see that people are going to be randomly
> using it to disable the CEC.
For me, "enable" is useful to make mcelog work like before. Please see the
other email from me for all the details.
For debugfs, I believe many productions mount it, as tracing still uses debugfs
rather than tracefs (at least on CentOS7), and rasdaemon also uses trace
events to collect different errors.
Therefore, I believe your patch is fine as it is.