Re: [PATCH] RAS/CEC: Add debugfs switch to disable at run time
From: Borislav Petkov
Date: Mon Apr 22 2019 - 14:08:43 EST
On Mon, Apr 22, 2019 at 10:44:15AM -0700, Luck, Tony wrote:
> Yes. Automating this would be a very good idea.
Yeah, in general integrating the CEC better with the rest of the error
chain is something we still need to discuss and do.
> In the case of many errors at different addresses we are deleting
> the entry with the lowest count. But all of the entries have low
> counts because we are just thrashing the array with many different
> addresses. In this situation a warning would be helpful.
Can we detect that situation reliably even? You can have many errors at
different addresses which have accumulated over time, due to a slow but
constant stream of errors. Dunno if that is possible though... someone
needs to analyze error occurrence patterns :-\
> But in the case where the system has been up for months and
> we very slowly accumlated logs of bit flips. The periodic
> spring cleaning means they all have generation "00", but
> we never actually drop an old entry because of age.
Yes, we drop only on insertion and when the array is full or when we
> In this case dropping one entry to make space for a new one is fine
> and doesn't need any action.
> Perhaps we can distinguish the cases by the generation? If
> we are dropping an entry that was recently added, then it
> will still have generation "11" (or at least not "00").
> Use that to trigger an action?
That and the fact that we're in an error storm is probably a good enough
heurstic. And then when the storm subsides, we reenable it? We basically
say, error storm is over, the error rate should go back to normal so we
can stick the CEC in front of it again.
Good mailing practices for 400: avoid top-posting and trim the reply.