Re: [PATCH v6 2/3] dt-bindings: backlight: add lm3630a bindings
From: Rob Herring
Date: Wed Apr 24 2019 - 11:58:05 EST
On Wed, Apr 24, 2019 at 9:20 AM Pavel Machek <pavel@xxxxxx> wrote:
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> > @@ -0,0 +1,129 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/lm3630a-backlight.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> I'm not a great fan on links to external websites. But this is comment
> for Rob.
This is simply how json-schema works. $schema says what meta-schema
this file should validate against so it's versioned if we change the
schema format. $id is just a unique identifier and is used to resolve
$ref values. Note that these aren't live urls either (but could be at
some point in the future).
> > +title: TI LM3630A High-Efficiency Dual-String White LED
> > +
> > +maintainers:
> > + - Lee Jones <lee.jones@xxxxxxxxxx>
> > + - Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > + - Jingoo Han <jingoohan1@xxxxxxxxx>
> Not a great fan of duplicating MAINTAINERS information here. But this
> is a comment for Rob, again.
Hopefully this is temporary until we move to per directory MAINTAINERS
files. Not sure what happened with that.