Re: [RFC PATCH v2 11/17] sched: Basic tracking of matching tasks

From: Vineeth Remanan Pillai
Date: Wed Apr 24 2019 - 16:44:07 EST


> A minor nitpick. I find keeping the vruntime base readjustment in
> core_prio_less probably is more straight forward rather than pass a
> core_cmp bool around.

The reason I moved the vruntime base adjustment to __prio_less is
because, the vruntime seemed alien to __prio_less when looked as
a standalone function.

I do not have a strong opinion on both. Probably a better approach
would be to replace both cpu_prio_less/core_prio_less with prio_less
which takes the third arguement 'bool on_same_rq'?

Thanks