Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs
From: Greg Kroah-Hartman
Date: Thu Apr 25 2019 - 13:46:20 EST
On Tue, Apr 16, 2019 at 06:03:58PM +0900, Jason A. Donenfeld wrote:
> On Tue, Apr 16, 2019 at 4:27 PM Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> > This patch aims to suppress up to 18 missing-break-in-switch false
> > positives on some architectures.
> > Cc: Jason A. Donenfeld <Jason@xxxxxxxxx>
> > Cc: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
> > Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> > Signed-off-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
> Looks good to me, thanks for this.
> Reviewed-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
> Perhaps Greg can take it through his tree?
Me? Ok, fine, I'll go queue it up...