Re: [v3 1/2] device-dax: fix memory and resource leak if hotplug fails

From: Pavel Tatashin
Date: Thu Apr 25 2019 - 14:51:52 EST


On Thu, Apr 25, 2019 at 2:32 PM Dave Hansen <dave.hansen@xxxxxxxxx> wrote:
>
> On 4/25/19 10:54 AM, Pavel Tatashin wrote:
> > rc = add_memory(numa_node, new_res->start, resource_size(new_res));
> > - if (rc)
> > + if (rc) {
> > + release_resource(new_res);
> > + kfree(new_res);
> > return rc;
> > + }
>
> Looks good to me:
>
> Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxx>

Thank you Dave.

Pasha