Re: [EXT] Re: [PATCH v2 07/15] spi: imx: remove ERR009165 workaround on i.mx6ul

[Robin Gong]

On 2019-04-26 at 11:09 +0200, Lucas Stach wrote:
>Â
> > Âstatic inline int is_imx53_ecspi(struct spi_imx_data *d)
> > @@ -585,9 +587,16 @@ static int mx51_ecspi_prepare_transfer(struct
> > spi_imx_data *spi_imx,
> > ÂÂÂÂÂÂctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, &clk);
> > ÂÂÂÂÂÂspi_imx->spi_bus_clk = clk;
> > 
> > -ÂÂÂÂÂ/* ERR009165: work in XHC mode as PIO */
> > -ÂÂÂÂÂif (spi_imx->usedma)
> > -ÂÂÂÂÂÂÂÂÂÂÂÂÂctrl &= ~MX51_ECSPI_CTRL_SMC;
> > +ÂÂÂÂÂ/*
> > +ÂÂÂÂÂÂ* ERR009165: work in XHC mode instead of SMC as PIO on the
> > chips
> > +ÂÂÂÂÂÂ* before i.mx6ul.
> > +ÂÂÂÂÂÂ*/
> > +ÂÂÂÂÂif (spi_imx->usedma) {
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂif (spi_imx->devtype_data->devtype == IMX6UL_ECSPI)
> > 
> > =, otherwise the workaround might be applied to later generations
> > of
> the core if more are added later.
> 
> Regards,
> Lucas
Understood your point, but for now choose different compatible name
could apply this workaround or not. I prefer to leave it for next ecspi
IP upgrade if it really come in the future, otherwise that '>=' bring
a little bit confuse if there is no update for ecspi IP...