Re: [PATCH v2] memcg: refill_stock for kmem uncharging too
From: Shakeel Butt
Date: Sun Apr 28 2019 - 19:54:40 EST
On Wed, Apr 24, 2019 at 11:49 PM Michal Hocko <mhocko@xxxxxxxxxx> wrote:
> On Tue 23-04-19 08:44:05, Shakeel Butt wrote:
> > The commit 475d0487a2ad ("mm: memcontrol: use per-cpu stocks for socket
> > memory uncharging") added refill_stock() for skmem uncharging path to
> > optimize workloads having high network traffic. Do the same for the kmem
> > uncharging as well. Though we can bypass the refill for the offlined
> > memcgs but it may impact the performance of network traffic for the
> > sockets used by other cgroups.
> While the change makes sense, I would really like to see what kind of
> effect on performance does it really have. Do you have any specific
> workload that benefits from it?
Thanks for the review. I will run some benchmarks and report back later.