Re: [PATCH v2] soc: add aspeed folder and misc drivers
From: Patrick Venture
Date: Mon Apr 29 2019 - 13:12:22 EST
On Mon, Apr 29, 2019 at 10:08 AM Olof Johansson <olof@xxxxxxxxx> wrote:
> On Thu, Apr 25, 2019 at 07:25:49PM +0200, Greg KH wrote:
> > On Tue, Apr 23, 2019 at 08:28:14AM -0700, Patrick Venture wrote:
> > > On Tue, Apr 23, 2019 at 8:22 AM Patrick Venture <venture@xxxxxxxxxx> wrote:
> > > >
> > > > On Tue, Apr 23, 2019 at 7:26 AM Patrick Venture <venture@xxxxxxxxxx> wrote:
> > > > >
> > > > > Create a SoC folder for the ASPEED parts and place the misc drivers
> > > > > currently present into this folder. These drivers are not generic part
> > > > > drivers, but rather only apply to the ASPEED SoCs.
> > > > >
> > > > > Signed-off-by: Patrick Venture <venture@xxxxxxxxxx>
> > > >
> > > > Accidentally lost the Acked-by when re-sending this patchset as I
> > > > didn't see it on v1 before re-sending v2 to the larger audience.
> > >
> > > Since there was a change between v1 and v2, Arnd, I'd appreciate you
> > > Ack this version of the patchset since it changes when the soc/aspeed
> > > Makefile is followed.
> > I have no objection for moving stuff out of drivers/misc/ so the SOC
> > maintainers are free to take this.
> > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> I'm totally confused. This is the second "PATCH v2" of this patch that I came
> across, I already applied the first.
I think the issue here was that I added to the CC list another email
and so you may see the v2 without that mailing list, and a v2 with it
Does this require a v3? I honestly didn't think so, but this was the
first time I had to add more people without needing other changes.
> Patrick: Follow up with incremental patch in case there's any difference.
> Meanwhile, please keep in mind that you're adding a lot of work for people when
> you respin patches without following up on the previous version. Thanks!
w.r.t this patch series. I found an issue with v1, and released a v2
with the detail of what changed. I thought that was the correct
approach. I apologize for creating extra work, that's something