Re: linux-next: Tree for Apr 29 (drivers/leds/leds-turris-omnia)
From: Marek Behun
Date: Mon Apr 29 2019 - 15:02:26 EST
On Mon, 29 Apr 2019 20:49:59 +0200
"Enrico Weigelt, metux IT consult" <lkml@xxxxxxxxx> wrote:
> On 29.04.19 20:12, Pavel Machek wrote:
> >> Is that controller only built-in into some SoCs, or also available
> >> as a separate chip ?
> > AFAIU.. separate chip, but runs firmware not likely to be available
> > outside Turris routers.
> hmm, if it's a separate chip, IMHO it should be selectable, so that
> anybody who puts that chip on his board can directly use it.
The chip is a cortex-m3 or something like that. What makes the LEDs
work in this specific way this driver uses is the firmware on the chip,
and that firmware is specific for Omnia.
It is possible that in the future someone makes a I2C controller
compatible with the API the Omnia firmware provides, but very unlikely.
I think it is reasonable to make the driver depend on MACH_ARMADA_38X
and in the unlikely scenario that someone makes a compatible
controller, the dependency can always be removed.
situation it is possible to