Re: [PATCH V2 0/5] mmc: mmci: add busy detect for stm32 sdmmc variant

From: Ulf Hansson
Date: Tue Apr 30 2019 - 07:14:39 EST


On Fri, 26 Apr 2019 at 09:46, Ludovic Barre <ludovic.Barre@xxxxxx> wrote:
>
> From: Ludovic Barre <ludovic.barre@xxxxxx>
>
> This patch series adds busy detect for stm32 sdmmc variant.
> Some adaptations are required:
> -Avoid to check and poll busy status when is not expected.
> -Clear busy status bit if busy_detect_flag and busy_detect_mask are
> different.
> -Add hardware busy timeout with MMCIDATATIMER register.
>
> V2:
> -mmci_cmd_irq cleanup in separate patch.
> -simplify the busy_detect_flag exclude
> -replace sdmmc specific comment in
> "mmc: mmci: avoid fake busy polling in mmci_irq"
> to focus on common behavior
>
> Ludovic Barre (5):
> mmc: mmci: cleanup mmci_cmd_irq for busy detect feature
> mmc: mmci: avoid fake busy polling in mmci_irq
> mmc: mmci: fix clear of busy detect status
> mmc: mmci: add hardware busy timeout feature
> mmc: mmci: add busy detect for stm32 sdmmc variant
>
> drivers/mmc/host/mmci.c | 61 ++++++++++++++++++++++++++++++++++++++-----------
> drivers/mmc/host/mmci.h | 3 +++
> 2 files changed, 51 insertions(+), 13 deletions(-)
>
> --
> 2.7.4
>

Ludovic, just wanted to let you know that I am reviewing and testing
this series.

However, while running some tests on Ux500 for validating the busy
detection code, even without your series applied, I encounter some odd
behaviors. I am looking into the problem to understand better and will
let you know as soon as I have some more data to share.

Kind regards
Uffe