Re: perf build broken in 5.1-rc7

[Thomas Backlund]

Den 01-05-2019 kl. 20:31, skrev Arnaldo Carvalho de Melo:
> Em Wed, May 01, 2019 at 05:09:59PM +0300, Thomas Backlund escreveu:
> > Den 01-05-2019 kl. 16:07, skrev Arnaldo Carvalho de Melo:
> > > Em Tue, Apr 30, 2019 at 04:31:14PM +0300, Thomas Backlund escreveu:
> > > Can you check the output for
> > > /tmp/build/perf/feature/test-disassembler-four-args.make.output in your
> > > system? And also check what is the prototype for the disassembler()
> > > routine on mageia7?
> > I guess this is what fails the test:
>   
> > cat /tmp/build/perf/feature/test-disassembler-four-args.make.output
> > /usr/bin/ld: /usr/lib64/libbfd.a(plugin.o): in function `try_load_plugin':
> > /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:243:
> > undefined reference to `dlopen'
> > /usr/bin/ld:
> > /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:271:
> > undefined reference to `dlsym'
> > /usr/bin/ld:
> > /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:256:
> > undefined reference to `dlclose'
> > /usr/bin/ld:
> > /home/iurt/rpmbuild/BUILD/binutils-2.32/objs/bfd/../../bfd/plugin.c:246:
> > undefined reference to `dlerror'
>   
> > as we allow dynamic linking and loading
>   
> > And we use linker flags:
>   
> > rpm --eval %ldflags
> >   -Wl,--as-needed -Wl,--no-undefined -Wl,-z,relro -Wl,-O1 -Wl,--build-id
> > -Wl,--enable-new-dtags
> Would this help?
>
> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> index fe3f97e342fa..6d65874e16c3 100644
> --- a/tools/perf/Makefile.config
> +++ b/tools/perf/Makefile.config
> @@ -227,7 +227,7 @@ FEATURE_CHECK_LDFLAGS-libpython-version := $(PYTHON_EMBED_LDOPTS)
>   
>   EATURE_CHECK_LDFLAGS-libaio = -lrt
>   
> -FEATURE_CHECK_LDFLAGS-disassembler-four-args = -lbfd -lopcodes
> +FEATURE_CHECK_LDFLAGS-disassembler-four-args = -lbfd -lopcodes -ldl
>   
>   CFLAGS += -fno-omit-frame-pointer
>   CFLAGS += -ggdb3

Yeah, that fixes it

and /tmp/build/perf/feature/test-disassembler-four-args.make.output is now empty as wanted.


So I guess:

Reported-by: Thomas Backlund <tmb@xxxxxxxxxx>

Tested-by: Thomas Backlund <tmb@xxxxxxxxxx>



Thanks!


--

Thomas