Re: [RESEND PATCH v3 05/11] mtd: rawnand: vf610_nfc: add initializer to avoid -Wmaybe-uninitialized
From: Miquel Raynal
Date: Fri May 03 2019 - 07:12:27 EST
Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote on Fri, 3 May
2019 19:36:35 +0900:
> Hi Miquel,
> On Thu, May 2, 2019 at 11:14 PM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> > Hi Masahiro,
> > Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx> wrote on Tue, 23 Apr
> > 2019 12:49:53 +0900:
> > > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common
> > > place. We need to eliminate potential issues beforehand.
> > >
> > > Kbuild test robot has never reported -Wmaybe-uninitialized warning
> > > for this probably because vf610_nfc_run() is inlined by the x86
> > > compiler's inlining heuristic.
> > >
> > > If CONFIG_OPTIMIZE_INLINING is enabled for a different architecture
> > > and vf610_nfc_run() is not inlined, the following warning is reported:
> > >
> > > drivers/mtd/nand/raw/vf610_nfc.c: In function âvf610_nfc_cmdâ:
> > > drivers/mtd/nand/raw/vf610_nfc.c:455:3: warning: âoffsetâ may be used uninitialized in this function [-Wmaybe-uninitialized]
> > > vf610_nfc_rd_from_sram(instr->ctx.data.buf.in + offset,
> > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > nfc->regs + NFC_MAIN_AREA(0) + offset,
> > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > > trfr_sz, !nfc->data_access);
> > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > IMHO this patch has no dependencies with this series.
> This patch is the prerequisite for 11/11.
> Without the correct patch order,
> the kbuild test robot reports the warning.
> > Would you mind sending it alone with the proper Fixes tag?
> I do not think Fixes is necessary.
IMHO it is. Even if today the warning does not spawn, there is a
real C error which might already be an issue.
> Nobody has noticed this potential issue before.
> Without 11/11, probably we cannot reproduce this warning.
> BTW, this series has been for a while in linux-next.
Missed that. Ok, nevermind.