Re: [GIT PULL 12/22] intel_th: msu: Support multipage blocks

From: Greg Kroah-Hartman
Date: Fri May 03 2019 - 12:15:52 EST


On Fri, May 03, 2019 at 11:44:45AM +0300, Alexander Shishkin wrote:
> @@ -1481,7 +1501,7 @@ nr_pages_show(struct device *dev, struct device_attribute *attr, char *buf)
> else if (msc->mode == MSC_MODE_MULTI) {
> list_for_each_entry(win, &msc->win_list, entry) {
> count += scnprintf(buf + count, PAGE_SIZE - count,
> - "%d%c", win->nr_blocks,
> + "%d%c", win->nr_pages,
> msc_is_last_win(win) ? '\n' : ',');
> }
> } else {

Why do you have a sysfs file that has multiple values? I will not take
a patch that adds to this mess, please remove this file and fix it up
properly.

thanks,

greg k-h