Re: [RFC][PATCH 1/2] x86: Allow breakpoints to emulate call functions
From: Steven Rostedt
Date: Fri May 03 2019 - 12:49:41 EST
On Fri, 3 May 2019 09:44:35 -0700
Andy Lutomirski <luto@xxxxxxxxxx> wrote:
> On Fri, May 3, 2019 at 9:35 AM Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> > On Fri, May 03, 2019 at 12:31:26PM -0400, Steven Rostedt wrote:
> > > I guess the real question is, what's the performance impact of doing
> > > that?
> > Is there anyone that considers i386 a performance platform?
> Not me. As far as I'm concerned, I will basically always gladly trade
> several cycles for simplicity on 32-bit.
So should I wait for a new PATCH 1 from Peter to implement it this way?
I'd like to get this into the next merge window (although, I am marking
it for stable since it fixes a bug for live kernel patching).
Linus, what's your thoughts?