RE: [EXT] Re: [PATCH v2 08/15] dt-bindings: spi: imx: add i.mx6ul to state errata fixed
From: Robin Gong
Date: Sun May 05 2019 - 04:56:21 EST
> On Fri, Apr 26, 2019 at 08:05:51AM +0000, Robin Gong wrote:
> > ERR009165 fixed from i.mx6ul, add it to show the errata fixed.
> > Signed-off-by: Robin Gong <yibin.gong@xxxxxxx>
> > ---
> > Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 2 ++
> > 1 file changed, 2 insertions(+)
> > diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> > b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> > index 2d32641..32c4263d 100644
> > --- a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> > +++ b/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt
> > @@ -10,6 +10,8 @@ Required properties:
> > - "fsl,imx35-cspi" for SPI compatible with the one integrated on i.MX35
> > - "fsl,imx51-ecspi" for SPI compatible with the one integrated on i.MX51
> > - "fsl,imx53-ecspi" for SPI compatible with the one integrated on
> > i.MX53 and later Soc
> > + - "fsl,imx6ul-ecspi" ERR009165 fixed on i.MX6UL and later Soc
> > +
> > + (https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fw
> > +
> > +
> > +
> > + 6aEFkNlY5KU9qNiqqFMuDEfqGNrzADDiPO9gQ%3D&reserved=0)
> What about other i.MX6 chips?
I only state in the cover letter of this patch set, for i.mx6q/dl/sl/sx still need this
errata which is fixed i.mx chips after i.mx6ul including i.mx6ull,i.mx8m,i.mx8mm.
I'll double confirm again and describe it clearly in commit log in v3.
> Seems like this is missing some fallbacks. The binding doc should make it clear
> what are all valid combinations of compatible strings.
In another Uwe's comment, I'm thinking move such errata information into spi
driver level which makes binding doc clear. What do you think?
> > - "fsl,imx8mq-ecspi" for SPI compatible with the one integrated on
> > i.MX8M
> > - reg : Offset and length of the register set for the device
> > - interrupts : Should contain CSPI/eCSPI interrupt
> > --
> > 2.7.4