Re: [PATCH] net: phy: sfp: enable i2c-bus detection on ACPI based systems

From: Heiner Kallweit
Date: Sun May 05 2019 - 16:00:42 EST


On 05.05.2019 21:34, Ruslan Babayev wrote:
> Signed-off-by: Ruslan Babayev <ruslan@xxxxxxxxxxx>
> Cc: xe-linux-external@xxxxxxxxx
> ---
> drivers/i2c/i2c-core-acpi.c | 3 ++-
> drivers/net/phy/sfp.c | 33 +++++++++++++++++++++++++--------
> include/linux/i2c.h | 6 ++++++
> 3 files changed, 33 insertions(+), 9 deletions(-)
>
Regarding the formal part:
- It should be [PATCH net-next]
- Commit description is missing (scripts/checkpatch.pl should have complained)

And maybe it would be better to split exporting i2c_acpi_find_adapter_by_handle
and extending sfp.c to two patches. If Wolfram acks the i2c patch, then I think
the series could go through the netdev tree. Eventually up to David.