Re: [RFC PATCH 1/4] dt-bindings: input: Add support for the MPR121 without interrupt line

[Michal VokÃÄ]

On 02. 05. 19 2:48, Rob Herring wrote:
> On Fri, Apr 26, 2019 at 10:30:17AM +0200, Michal VokÃÄ wrote:
> > Normally, the MPR121 controller uses separate interrupt line to notify
> > the I2C host that a key was touched/released. To support platforms that
> > can not use the interrupt line, polling of the MPR121 registers can be
> > used.
>
> Other than making the 'interrupts' property optional, that's a driver
> change, not a DT change. IOW, we shouldn't need a whole new binding.

OK, I will update the existing binding instead.

Thank you,
Michal

> > Signed-off-by: Michal VokÃÄ <michal.vokac@xxxxxxxxx>
> > ---
> >   .../bindings/input/mpr121-touchkey-polled.txt      | 26 ++++++++++++++++++++++
> >   1 file changed, 26 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/input/mpr121-touchkey-polled.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/mpr121-touchkey-polled.txt b/Documentation/devicetree/bindings/input/mpr121-touchkey-polled.txt
> > new file mode 100644
> > index 000000000000..6bb1d312614c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/mpr121-touchkey-polled.txt
> > @@ -0,0 +1,26 @@
> > +* Freescale MPR121 Controller without interrupt line
> > +
> > +Required Properties:
> > +- compatible:		Should be "fsl,mpr121-touchkey-polled"
> > +- reg:			The I2C slave address of the device.
> > +- vdd-supply:		Phandle to the Vdd power supply.
> > +- linux,keycodes:	Specifies an array of numeric keycode values to
> > +			be used for reporting button presses. The array can
> > +			contain up to 12 entries.
> > +
> > +Optional Properties:
> > +- autorepeat:		Enable autorepeat feature.
> > +
> > +Example:
> > +
> > +#include "dt-bindings/input/input.h"
> > +
> > +	touchkeys: keys@5a {
> > +		compatible = "fsl,mpr121-touchkey-polled";
> > +		reg = <0x5a>;
> > +		autorepeat;
> > +		vdd-supply = <&ldo4_reg>;
> > +		linux,keycodes = <KEY_0>, <KEY_1>, <KEY_2>, <KEY_3>,
> > +				<KEY_4> <KEY_5>, <KEY_6>, <KEY_7>,
> > +				<KEY_8>, <KEY_9>, <KEY_A>, <KEY_B>;
> > +	};
> > --
> > 2.1.4