Re: [PATCH net-next 0/4] net: mvpp2: cls: Add classification
From: Jakub Kicinski
Date: Mon May 06 2019 - 13:55:03 EST
On Mon, 6 May 2019 10:00:26 +0200, Maxime Chevallier wrote:
> Hello Jakub,
> On Sat, 4 May 2019 02:53:53 -0400
> Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> wrote:
> >On Tue, 30 Apr 2019 15:14:25 +0200, Maxime Chevallier wrote:
> >> Compared to the first submissions, the NETIF_F_NTUPLE flag was also
> >> removed, following Saeed's comment.
> >You should probably add it back, even though the stack only uses
> >NETIF_F_NTUPLE for aRFS the ethtool APIs historically depend on the
> >drivers doing a lot of the validation.
> OK my bad, reading your previous comments again, I should indeed have
> left it.
> I'll re-add the flag, do you think this should go through -net or wait
> until net-next reopens ?
I think the patch should be relatively simple and clean? So I'd try for
net, with a Fixes tag, it's a slight ABI correction and we are still
in the merge window period. So I'd go for net :)