Re: [PATCH 17/18] perf/x86/intel/rapl: Support multi-die/package

From: Ingo Molnar
Date: Mon May 06 2019 - 15:50:26 EST



* Len Brown <lenb@xxxxxxxxxx> wrote:

> On Mon, May 6, 2019 at 7:48 AM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> > > - unsigned int pkgid = topology_logical_package_id(cpu);
> > > + unsigned int pkgid = topology_logical_die_id(cpu);
>
> > There's many such instances left in this series, please review the whole
> > patchset for such problems.
>
> I agree, the legacy names make the code read as if it were a bug, even
> when it is correct.
> I'll refresh the series with some re-names to make the end result ready clearly.

Thanks a lot!

Ingo