Re: [PATCH] serial: 8250: Add support for using platform_device resources
From: Esben Haabendal
Date: Tue May 07 2019 - 08:23:17 EST
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
> On Tue, May 07, 2019 at 01:35:58PM +0200, Esben Haabendal wrote:
>> Lee Jones <lee.jones@xxxxxxxxxx> writes:
>> > On Thu, 02 May 2019, Esben Haabendal wrote:
>> >> Could you help clarify whether or not this patch is trying to do
>> >> something odd/wrong?
>> >> I might be misunderstanding Andy (probably is), but the discussion
>> >> revolves around the changes I propose where I change the serial8250
>> >> driver to use platform_get_resource() in favour of
>> >> request_mem_region()/release_mem_region().
>> > Since 'serial8250' is registered as a platform device, I don't see any
>> > reason why it shouldn't have the capability to obtain its memory
>> > regions from the platform_get_*() helpers.
>> Good to hear. That is exactly what I am trying do with this patch.
>> @Andy: If you still don't like my approach, could you please advice an
>> acceptable method for improving the serial8250 driver to allow the use
>> of platform_get_*() helpers?
> I still don't get why you need this.
Because platform_get_resource() is a generally available and useful
helper function for working with platform_device resources, that the
current standard serial8250 driver does not support.
I am uncertain if I still haven't convinced you that current serial8250
driver does not work with platform_get_resource(), or if you believe
that it really should not support it.
> If it's MFD, you may use "serial8250" with a given platform data like
> dozens of current users do.
There is only one in-tree mfd driver using "serial8250", the sm501.c
driver. And that driver predates the mfd framework (mfd-core.c) by a
year, and does not use any of the mfd-core functionality.
I want to use the mfd-core provided handling of resource splitting,
because it makes it easier to handle splitting of a single memory
resource as defined by a PCI BAR in this case. And the other drivers I
need to use all support/use platform_get_resource(), so it would even
have an impact on the integration of that if I cannot use mfd resource
splitting with serial8250.
> Another approach is to use 8250 library, thus, creating a specific glue driver
> (like all 8250_* do).
As mentioned, I think this is a bad approach, and I would prefer to
improve the "serial8250" driver instead. But if you insist, what should
I call such a driver? It needs a platform_driver name, for use when
matching with platform_device devices. And it would support exactly the
same hardware as the current "serial8250" driver.
> Yes, I understand that 8250 driver is full of quirks and not modern approaches
> to do one or another thing. Unfortunately it's not too easy to fix it without
> uglifying code and doing some kind of ping-pong thru the conversion. I don't
> think it worth to do it in the current state of affairs. Though, cleaning up
> the core part from the quirks and custom pieces would make this task
I think it should be possible and worthwhile to improve serial8250
driver with support for using platform_device resources
If we could stop discussing if it is a proper thing to do, we could try
to find a good way to do it instead.
> I'm also puzzled why you don't use FPGA manager which should handle, as far as
> I understand, very flexible configurations of FPGAs.
FPGA manager is for programming FPGA's. The FPGA's used in this project
read their configuration from EEPROM.
I don't see any overlap of FPGA manager with MFD. They server
completely different purposes, and could very well both be used for the
> Btw, what exact IP of UART do you have implemented there?
It is an XPS 16550 UART (v3.00a).
There are 5 of them in one FPGA, together with 3 XPS LL TEMAC Ethernet
IP blocks, an IRQ controller, and a number of custom IP blocks.