Re: [REGRESSION] usb: gadget: f_fs: Allow scatter-gather buffers

From: Andrzej Pietrasiewicz
Date: Wed May 08 2019 - 03:02:29 EST

Hi John,

+= Marek

W dniu 08.05.2019 oÂ04:18, John Stultz pisze:
Since commit 772a7a724f69 ("usb: gadget: f_fs: Allow scatter-gather
buffers"), I've been seeing trouble with adb transfers in Android on
HiKey960, HiKey and now Dragonboard 845c.

Sometimes things crash, but often the transfers just stop w/o any
obvious error messages.

Initially I thought it was an issue with the HiKey960 dwc3 usb patches
being upstreamed, and was using the following hack workaround:

Then dwc2 added sg support, and I ended up having to revert it to get
by on HiKey:

(See thread here:

And now I've reproduced the same issue (with the same dwc3 workaround)
on the already upstream code for Dragonboard 845c.

Fei Yang has also reached out and mentioned he was seeing similar
problems with the f_fs sg support.

Andrzej: Do you have any ideas or suggestions on this? I'm happy to
test or run any debug patches, if it would help narrow the issue down.

There is a patch:

which fixes a subtle bug, but hasn't been applied yet.

Can you please try it?

If not, should we consider reverting the f_fs sg support?