Re: [PATCH v7 08/13] drivers: memory: add DMC driver for Exynos5422

From: Krzysztof Kozlowski
Date: Wed May 08 2019 - 03:13:02 EST

())On Mon, 6 May 2019 at 17:12, Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx> wrote:
>
> This patch adds driver for Exynos5422 Dynamic Memory Controller.
> The driver provides support for dynamic frequency and voltage scaling for
> DMC and DRAM. It supports changing timings of DRAM running with different
> frequency. There is also an algorithm to calculate timigns based on
> memory description provided in DT.
> The patch also contains needed MAINTAINERS file update.
>
> Signed-off-by: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx>
> ---
> MAINTAINERS | 8 +
> drivers/memory/samsung/Kconfig | 17 +
> drivers/memory/samsung/Makefile | 1 +
> drivers/memory/samsung/exynos5422-dmc.c | 1761 +++++++++++++++++++++++++++++++
> 4 files changed, 1787 insertions(+)
> create mode 100644 drivers/memory/samsung/exynos5422-dmc.c
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8ac65e4..c7abb73 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3396,6 +3396,14 @@ S: Maintained
> F: drivers/devfreq/exynos-bus.c
> F: Documentation/devicetree/bindings/devfreq/exynos-bus.txt
>
> +DMC FREQUENCY DRIVER FOR SAMSUNG EXYNOS5422
> +M: Lukasz Luba <l.luba@xxxxxxxxxxxxxxxxxxx>
> +L: linux-pm@xxxxxxxxxxxxxxx
> +L: linux-samsung-soc@xxxxxxxxxxxxxxx
> +S: Maintained
> +F: drivers/memory/samsung/exynos5422-dmc.c
> +F: Documentation/devicetree/bindings/memory-controllers/exynos5422-dmc.txt
> +
> BUSLOGIC SCSI DRIVER
> M: Khalid Aziz <khalid@xxxxxxxxxxxxxx>
> L: linux-scsi@xxxxxxxxxxxxxxx
> diff --git a/drivers/memory/samsung/Kconfig b/drivers/memory/samsung/Kconfig
> index 79ce7ea..202972b 100644
> --- a/drivers/memory/samsung/Kconfig
> +++ b/drivers/memory/samsung/Kconfig
> @@ -5,6 +5,23 @@ config SAMSUNG_MC
> Support for the Memory Controller (MC) devices found on
> Samsung Exynos SoCs.
>
> +config ARM_EXYNOS5422_DMC
> + tristate "ARM EXYNOS5422 Dynamic Memory Controller driver"
> + depends on ARCH_EXYNOS || COMPILE_TEST
> + select DDR
> + select PM_DEVFREQ
> + select DEVFREQ_GOV_SIMPLE_ONDEMAND
> + select DEVFREQ_GOV_USERSPACE
> + select PM_DEVFREQ_EVENT
> + select PM_OPP
> + help
> + This adds driver for Exynos5422 DMC (Dynamic Memory Controller).
> + The driver provides support for Dynamic Voltage and Frequency Scaling in
> + DMC and DRAM. It also supports changing timings of DRAM running with
> + different frequency. The timings are calculated based on DT memory
> + information.
> +
> +
> if SAMSUNG_MC
>
> config EXYNOS_SROM
> diff --git a/drivers/memory/samsung/Makefile b/drivers/memory/samsung/Makefile
> index 00587be..4f6e438 100644
> --- a/drivers/memory/samsung/Makefile
> +++ b/drivers/memory/samsung/Makefile
> @@ -1,2 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0
> +obj-$(CONFIG_ARM_EXYNOS5422_DMC) += exynos5422-dmc.o
> obj-$(CONFIG_EXYNOS_SROM) += exynos-srom.o
> diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c
> new file mode 100644
> index 0000000..64e99b1
> --- /dev/null
> +++ b/drivers/memory/samsung/exynos5422-dmc.c
> @@ -0,0 +1,1761 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019 Samsung Electronics Co., Ltd.
> + */
> +
> +#include <linux/clk.h>
> +#include <linux/debugfs.h>
> +#include <linux/delay.h>
> +#include <linux/devfreq.h>
> +#include <linux/devfreq-event.h>
> +#include <linux/device.h>
> +#include <linux/io.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> +#include <linux/pm_opp.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/seq_file.h>
> +#include <linux/slab.h>
> +#include <memory/jedec_ddr.h>
> +#include "../of_memory.h"
> +
> +#define EXYNOS5_DREXI_TIMINGAREF (0x0030)
> +#define EXYNOS5_DREXI_TIMINGROW0 (0x0034)
> +#define EXYNOS5_DREXI_TIMINGDATA0 (0x0038)
> +#define EXYNOS5_DREXI_TIMINGPOWER0 (0x003C)
> +#define EXYNOS5_DREXI_TIMINGROW1 (0x00E4)
> +#define EXYNOS5_DREXI_TIMINGDATA1 (0x00E8)
> +#define EXYNOS5_DREXI_TIMINGPOWER1 (0x00EC)
> +#define CDREX_PAUSE (0x91c)
> +#define CDREX_LPDDR3PHY_CON3 (0xa20)
> +#define EXYNOS5_TIMING_SET_SWI (1UL << 28)
> +#define USE_MX_MSPLL_TIMINGS (1)
> +#define USE_BPLL_TIMINGS (0)
> +
> +#define EXYNOS5_AREF_NORMAL (0x2e)
> +
> +#define IS_MEM_2GB(val) \
> + ( \
> + (((val) & 0xf0) & 0x20) ? 1 : \
> + (((val) & 0xf0) & 0x30) ? 1 : 0 \
> + )
> +
> +#define EXYNOS5_POP_OPTIONS(val) (((val >> 4) & 0x3UL) << 4)
> +#define EXYNOS5_DDR_TYPE(val) (((val >> 14) & 0x1UL))
> +
> +#define EXYNOS5_CHIP_PROD_ID (0)
> +#define EXYNOS5_CHIP_PKG_ID (4)
> +
> +#define PPMU_PMCNT_CONST_RATIO_MUL 15
> +#define PPMU_PMCNT_CONST_RATIO_DIV 10
> +
> +#define AXI_BUS_WIDTH_BYTES (128 >> 3)
> +
> +enum dmc_slot_id {
> + DMC0_0,
> + DMC0_1,
> + DMC1_0,
> + DMC1_1,
> + DMC_SLOTS_END
> +};
> +
> +/**
> + * struct dmc_slot_info - Describes DMC's slot
> + *
> + * The structure holds DMC's slot name which is part of the device name
> + * provided in DT. Each slot has particular share of the DMC bandwidth.
> + * To abstract the model performance and values in performance counters,
> + * fields 'ratio_mul' and 'ratio_div' are used in calculation algorithm
> + * for each slot. Please check the corresponding function with the algorithm,
> + * to see how these variables are used.
> + */
> +struct dmc_slot_info {
> + char *name;
> + int id;
> + int ratio_mul;
> + int ratio_div;
> +};
> +
> +/**
> + * struct dmc_opp_table - Operating level desciption
> + *
> + * Covers frequency and voltage settings of the DMC operating mode.
> + */
> +struct dmc_opp_table {
> + u32 freq_hz;
> + u32 volt_uv;
> +};
> +
> +/**
> + * struct exynos5_dmc - main structure describing DMC device
> + *
> + * The main structure for the Dynamic Memory Controller which covers clocks,
> + * memory regions, HW information, parameters and current operating mode.
> + */
> +struct exynos5_dmc {
> + struct device *dev;
> + struct devfreq *df;
> + struct devfreq_simple_ondemand_data gov_data;
> + void __iomem *base_drexi0;
> + void __iomem *base_drexi1;
> + struct regmap *clk_regmap;
> + struct regmap *chipid_regmap;
> + struct mutex lock;
> + unsigned long curr_rate;
> + unsigned long curr_volt;
> + unsigned long bypass_rate;
> + struct dmc_opp_table *opp;
> + struct dmc_opp_table opp_bypass;
> + int opp_count;
> + u32 timings_arr_size;
> + u32 *timing_row;
> + u32 *timing_data;
> + u32 *timing_power;
> + const struct lpddr3_timings *timings;
> + const struct lpddr3_min_tck *min_tck;
> + u32 bypass_timing_row;
> + u32 bypass_timing_data;
> + u32 bypass_timing_power;
> + unsigned int prod_rev;
> + unsigned int pkg_rev;
> + unsigned int mem_info;
> + struct regulator *vdd_mif;
> + struct clk *fout_spll;
> + struct clk *fout_bpll;
> + struct clk *mout_spll;
> + struct clk *mout_bpll;
> + struct clk *mout_mclk_cdrex;
> + struct clk *dout_clk2x_phy0;
> + struct clk *mout_mx_mspll_ccore;
> + struct clk *mx_mspll_ccore_phy;
> + struct clk *mout_mx_mspll_ccore_phy;
> + struct devfreq_event_dev **counter;
> + int num_counters;
> +#ifdef CONFIG_DEBUG_FS
> + struct dentry *dbg_root;
> +#endif
> +};
> +
> +#define TIMING_FIELD(t_name, t_bit_beg, t_bit_end) \
> + { .name = t_name, .bit_beg = t_bit_beg, .bit_end = t_bit_end }
> +
> +#define TIMING_VAL(timing_array, id, t_val) \
> +({ \
> + u32 __val; \
> + __val = t_val << timing_array[id].bit_beg; \
> + __val; \
> +})
> +
> +#define TIMING_VAL2REG(timing, t_val) \
> +({ \
> + u32 __val; \
> + __val = t_val << timing->bit_beg; \
> + __val; \
> +})
> +
> +#define TIMING_REG2VAL(reg, timing) \
> +({ \
> + u32 __val; \
> + reg <<= (31 - timing->bit_end); \
> + reg >>= (31 - timing->bit_end); \
> + __val = reg >> timing->bit_beg; \
> + __val; \
> +})
> +
> +struct timing_reg {
> + char *name;
> + int bit_beg;
> + int bit_end;
> + unsigned int val;
> +};
> +
> +static const struct timing_reg timing_row[] = {
> + TIMING_FIELD("tRFC", 24, 31),
> + TIMING_FIELD("tRRD", 20, 23),
> + TIMING_FIELD("tRP", 16, 19),
> + TIMING_FIELD("tRCD", 12, 15),
> + TIMING_FIELD("tRC", 6, 11),
> + TIMING_FIELD("tRAS", 0, 5),
> +};
> +
> +static const struct timing_reg timing_data[] = {
> + TIMING_FIELD("tWTR", 28, 31),
> + TIMING_FIELD("tWR", 24, 27),
> + TIMING_FIELD("tRTP", 20, 23),
> + TIMING_FIELD("tW2W-C2C", 14, 14),
> + TIMING_FIELD("tR2R-C2C", 12, 12),
> + TIMING_FIELD("WL", 8, 11),
> + TIMING_FIELD("tDQSCK", 4, 7),
> + TIMING_FIELD("RL", 0, 3),
> +};
> +
> +static const struct timing_reg timing_power[] = {
> + TIMING_FIELD("tFAW", 26, 31),
> + TIMING_FIELD("tXSR", 16, 25),
> + TIMING_FIELD("tXP", 8, 15),
> + TIMING_FIELD("tCKE", 4, 7),
> + TIMING_FIELD("tMRD", 0, 3),
> +};
> +
> +#define TIMING_COUNT (ARRAY_SIZE(timing_row) + ARRAY_SIZE(timing_data) + \
> + ARRAY_SIZE(timing_power))
> +
> +static int exynos5_counters_set_event(struct exynos5_dmc *dmc)
> +{
> + int i, ret;
> +
> + for (i = 0; i < dmc->num_counters; i++) {
> + if (!dmc->counter[i])
> + continue;
> + ret = devfreq_event_set_event(dmc->counter[i]);
> + if (ret < 0)
> + return ret;
> + }
> + return 0;
> +}
> +
> +static int exynos5_counters_enable_edev(struct exynos5_dmc *dmc)
> +{
> + int i, ret;
> +
> + for (i = 0; i < dmc->num_counters; i++) {
> + if (!dmc->counter[i])
> + continue;
> + ret = devfreq_event_enable_edev(dmc->counter[i]);
> + if (ret < 0)
> + return ret;
> + }
> + return 0;
> +}
> +
> +static int exynos5_counters_disable_edev(struct exynos5_dmc *dmc)
> +{
> + int i, ret;
> +
> + for (i = 0; i < dmc->num_counters; i++) {
> + if (!dmc->counter[i])
> + continue;
> + ret = devfreq_event_disable_edev(dmc->counter[i]);
> + if (ret < 0)
> + return ret;
> + }
> + return 0;
> +}
> +
> +/* Event names to DMC channel and slot with proper data count type */
> +static const char *event_name[] = {
> + /* Counters for DMC0 slot 0 */
> + "ppmu-event0-dmc0_0",
> + "DMC0_0-Read",
> + "ppmu-event1-dmc0_0",
> + "DMC0_0-Write",
> + "ppmu-event3-dmc0_0",
> + "DMC0_0-Read+Write",
> + /* Counters for DMC0 slot 1 */
> + "ppmu-event0-dmc0_1",
> + "DMC0_1-Read",
> + "ppmu-event1-dmc0_1",
> + "DMC0_1-Write",
> + "ppmu-event3-dmc0_1",
> + "DMC0_1-Read+Write",
> + /* Counters for DMC1 slot 0 */
> + "ppmu-event0-dmc1_0",
> + "DMC1_0-Read",
> + "ppmu-event1-dmc1_0",
> + "DMC1_0-Write",
> + "ppmu-event3-dmc1_0",
> + "DMC1_0-Read+Write",
> + /* Counters for DMC1 slot 0 */
> + "ppmu-event0-dmc1_1",
> + "DMC1_1-Read",
> + "ppmu-event1-dmc1_1",
> + "DMC1_1-Write",
> + "ppmu-event3-dmc1_1",
> + "DMC1_1-Read+Write",
> +};
> +
> +/**
> + * find_target_freq_id() - Finds requested frequency in local DMC configuration
> + * @dmc: device for which the information is checked
> + * @target_rate: requested frequency in KHz
> + *
> + * Seeks in the local DMC driver structure for the requested frequency value
> + * and returns index or error value.
> + */
> +static int find_target_freq_idx(struct exynos5_dmc *dmc,
> + unsigned long target_rate)
> +{
> + int i;
> +
> + for (i = dmc->opp_count - 1; i >= 0; i--)
> + if (dmc->opp[i].freq_hz <= target_rate)
> + return i;
> +
> + return -EINVAL;
> +}
> +
> +/**
> + * exynos5_dmc_chip_revision_settings() - Chooses proper DMC's configuration
> + * @dmc: device for which is going to be checked and configured
> + *
> + * Function checks the HW product information in order to choose proper
> + * configuration for DMC frequency, voltage and DRAM timings.
> + */
> +static int exynos5_dmc_chip_revision_settings(struct exynos5_dmc *dmc)
> +{
> + unsigned int val;
> +
> + regmap_read(dmc->chipid_regmap, EXYNOS5_CHIP_PROD_ID, &val);
> + dmc->prod_rev = val;
> +
> + regmap_read(dmc->chipid_regmap, EXYNOS5_CHIP_PKG_ID, &val);
> + dmc->pkg_rev = val;

You do not use them later (prod_rev and pkg_rev) except debug message.
Don't store them only for that purpose... and you anyway do not need
to print prod_id/pkg_id. These are properties of SoC/chipid, not
properties of DMC. They could be printed by chipd driver but not by
other drivers.

Actually, you do not use mem_info either, so remove all of it.

> +
> + dmc->mem_info = EXYNOS5_POP_OPTIONS(val);
> + dmc->mem_info |= EXYNOS5_DDR_TYPE(val);
> +
> + if (!IS_MEM_2GB(dmc->mem_info)) {
> + dev_warn(dmc->dev, "DRAM memory type not supported\n");
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
> +
> +/**
> + * exynos5_switch_timing_regs() - Changes bank register set for DRAM timings
> + * @dmc: device for which the new settings is going to be applied
> + * @set: boolean variable passing set value
> + *
> + * Changes the register set, which holds timing parameters.
> + * There is two register sets: 0 and 1. The register set 0
> + * is used in normal operation when the clock is provided from main PLL.
> + * The bank register set 1 is used when the main PLL frequency is going to be
> + * changed and the clock is taken from alternative, stable source.
> + * This function switches between these banks according to the
> + * currently used clock source.
> + */
> +static void exynos5_switch_timing_regs(struct exynos5_dmc *dmc, bool set)
> +{
> + unsigned int reg;
> + int ret;
> +
> + ret = regmap_read(dmc->clk_regmap, CDREX_LPDDR3PHY_CON3, &reg);
> +
> + if (set)
> + reg |= EXYNOS5_TIMING_SET_SWI;
> + else
> + reg &= ~EXYNOS5_TIMING_SET_SWI;
> +
> + regmap_write(dmc->clk_regmap, CDREX_LPDDR3PHY_CON3, reg);
> +}
> +
> +/**
> + * exynos5_init_freq_table() - Initialized PM OPP framework
> + * @dev: devfreq device for which the OPP table is going to be
> + * initialized
> + * @dmc: DMC device for which the frequencies are used for OPP init
> + * @profile: devfreq device's profile
> + *
> + * Populate the devfreq device's OPP table based on current frequency, voltage.
> + */
> +static int exynos5_init_freq_table(struct device *dev, struct exynos5_dmc *dmc,
> + struct devfreq_dev_profile *profile)
> +{
> + int i, ret;
> + int idx;
> + unsigned long freq;
> +
> + ret = dev_pm_opp_of_add_table(dev);
> + if (ret < 0) {
> + dev_err(dev, "Failed to get OPP table\n");
> + return ret;
> + }
> +
> + dmc->opp_count = dev_pm_opp_get_opp_count(dev);
> +
> + dmc->opp = devm_kmalloc_array(dmc->dev, dmc->opp_count,
> + sizeof(struct dmc_opp_table), GFP_KERNEL);
> + if (!dmc->opp)
> + goto err_opp;
> +
> + idx = dmc->opp_count - 1;
> + for (i = 0, freq = ULONG_MAX; i < dmc->opp_count; i++, freq--) {
> + struct dev_pm_opp *opp;
> +
> + opp = dev_pm_opp_find_freq_floor(dev, &freq);
> + if (IS_ERR(opp))
> + goto err_free_tables;
> +
> + dmc->opp[idx - i].freq_hz = freq;
> + dmc->opp[idx - i].volt_uv = dev_pm_opp_get_voltage(opp);
> +
> + dev_pm_opp_put(opp);
> + }
> +
> + return 0;
> +
> +err_free_tables:
> + kfree(dmc->opp);
> +err_opp:
> + dev_pm_opp_of_remove_table(dev);
> +
> + return -EINVAL;
> +}
> +
> +/**
> + * exynos5_set_bypass_dram_timings() - Low-level changes of the DRAM timings
> + * @dmc: device for which the new settings is going to be applied
> + * @param: DRAM parameters which passes timing data
> + *
> + * Low-level function for changing timings for DRAM memory clocking from
> + * 'bypass' clock source (fixed frequency @400MHz).
> + * It uses timing bank registers set 1.
> + */
> +static void exynos5_set_bypass_dram_timings(struct exynos5_dmc *dmc)
> +{
> + writel(EXYNOS5_AREF_NORMAL,
> + dmc->base_drexi0 + EXYNOS5_DREXI_TIMINGAREF);
> +
> + writel(dmc->bypass_timing_row,
> + dmc->base_drexi0 + EXYNOS5_DREXI_TIMINGROW1);
> + writel(dmc->bypass_timing_row,
> + dmc->base_drexi1 + EXYNOS5_DREXI_TIMINGROW1);
> + writel(dmc->bypass_timing_data,
> + dmc->base_drexi0 + EXYNOS5_DREXI_TIMINGDATA1);
> + writel(dmc->bypass_timing_data,
> + dmc->base_drexi1 + EXYNOS5_DREXI_TIMINGDATA1);
> + writel(dmc->bypass_timing_power,
> + dmc->base_drexi0 + EXYNOS5_DREXI_TIMINGPOWER1);
> + writel(dmc->bypass_timing_power,
> + dmc->base_drexi1 + EXYNOS5_DREXI_TIMINGPOWER1);
> +}
> +
> +/**
> + * exynos5_dram_change_timings() - Low-level changes of the DRAM final timings
> + * @dmc: device for which the new settings is going to be applied
> + * @target_rate: target frequency of the DMC
> + *
> + * Low-level function for changing timings for DRAM memory operating from main
> + * clock source (BPLL), which can have different frequencies. Thus, each
> + * frequency must have corresponding timings register values in order to keep
> + * the needed delays.
> + * It uses timing bank registers set 0.
> + */
> +static int exynos5_dram_change_timings(struct exynos5_dmc *dmc,
> + unsigned long target_rate)
> +{
> + int idx;
> +
> + for (idx = dmc->opp_count - 1; idx >= 0; idx--)
> + if (dmc->opp[idx].freq_hz <= target_rate)
> + break;
> +
> + if (idx < 0)
> + return -EINVAL;
> +
> + writel(EXYNOS5_AREF_NORMAL,
> + dmc->base_drexi0 + EXYNOS5_DREXI_TIMINGAREF);
> +
> + writel(dmc->timing_row[idx],
> + dmc->base_drexi0 + EXYNOS5_DREXI_TIMINGROW0);
> + writel(dmc->timing_row[idx],
> + dmc->base_drexi1 + EXYNOS5_DREXI_TIMINGROW0);
> + writel(dmc->timing_data[idx],
> + dmc->base_drexi0 + EXYNOS5_DREXI_TIMINGDATA0);
> + writel(dmc->timing_data[idx],
> + dmc->base_drexi1 + EXYNOS5_DREXI_TIMINGDATA0);
> + writel(dmc->timing_power[idx],
> + dmc->base_drexi0 + EXYNOS5_DREXI_TIMINGPOWER0);
> + writel(dmc->timing_power[idx],
> + dmc->base_drexi1 + EXYNOS5_DREXI_TIMINGPOWER0);
> +
> + return 0;
> +}
> +
> +/**
> + * exynos5_dmc_align_target_voltage() - Sets the final voltage for the DMC
> + * @dmc: device for which it is going to be set
> + * @target_volt: new voltage which is chosen to be final
> + *
> + * Function tries to align voltage to the safe level for 'normal' mode.
> + * It checks the need of higher voltage and changes the value. The target
> + * voltage might be lower that currently set and still the system will be
> + * stable.
> + */
> +static int exynos5_dmc_align_target_voltage(struct exynos5_dmc *dmc,
> + unsigned long target_volt)
> +{
> + int ret = 0;
> +
> + if (dmc->curr_volt > target_volt) {
> + ret = regulator_set_voltage(dmc->vdd_mif, target_volt,
> + target_volt);
> + if (!ret)
> + dmc->curr_volt = target_volt;
> + }
> +
> + return ret;
> +}
> +
> +/**
> + * exynos5_dmc_align_bypass_voltage() - Sets the voltage for the DMC
> + * @dmc: device for which it is going to be set
> + * @target_volt: new voltage which is chosen to be final
> + *
> + * Function tries to align voltage to the safe level for the 'bypass' mode.
> + * It checks the need of higher voltage and changes the value.
> + * The target voltage must not be less than currently needed, because
> + * for current frequency the device might become unstable.
> + */
> +static int exynos5_dmc_align_bypass_voltage(struct exynos5_dmc *dmc,
> + unsigned long target_volt)
> +{
> + int ret = 0;
> + unsigned long bypass_volt = dmc->opp_bypass.volt_uv;
> +
> + target_volt = max(bypass_volt, target_volt);
> +
> + if (dmc->curr_volt >= target_volt)
> + return 0;
> +
> + ret = regulator_set_voltage(dmc->vdd_mif, target_volt,
> + target_volt);
> + if (!ret)
> + dmc->curr_volt = target_volt;
> +
> + return ret;
> +}
> +
> +/**
> + * exynos5_dmc_align_bypass_dram_timings() - Chooses and sets DRAM timings
> + * @dmc: device for which it is going to be set
> + * @target_rate: new frequency which is chosen to be final
> + *
> + * Function changes the DRAM timings for the temporary 'bypass' mode.
> + */
> +static int exynos5_dmc_align_bypass_dram_timings(struct exynos5_dmc *dmc,
> + unsigned long target_rate)
> +{
> + int idx = find_target_freq_idx(dmc, target_rate);
> +
> + if (idx < 0)
> + return -EINVAL;
> +
> + exynos5_set_bypass_dram_timings(dmc);
> +
> + return 0;
> +}
> +
> +/**
> + * exynos5_dmc_switch_to_bypass_configuration() - Switching to temporary clock
> + * @dmc: DMC device for which the switching is going to happen
> + * @target_rate: new frequency which is going to be set as a final
> + * @target_volt: new voltage which is going to be set as a final
> + *
> + * Function configures DMC and clocks for operating in temporary 'bypass' mode.
> + * This mode is used only temporary but if required, changes voltage and timings
> + * for DRAM chips. It switches the main clock to stable clock source for the
> + * period of the main PLL reconfiguration.
> + */
> +static int exynos5_dmc_switch_to_bypass_configuration(struct exynos5_dmc *dmc,
> + unsigned long target_rate,
> + unsigned long target_volt)
> +{
> + int ret;
> +
> + /*
> + * Having higher voltage for a particular frequency does not harm
> + * the chip. Use it for the temporary frequency change when one
> + * voltage manipulation might be avoided.
> + */
> + ret = exynos5_dmc_align_bypass_voltage(dmc, target_volt);
> + if (ret)
> + return ret;
> +
> + /*
> + * Longer delays for DRAM does not cause crash, the opposite does.
> + */
> + ret = exynos5_dmc_align_bypass_dram_timings(dmc, target_rate);
> + if (ret)
> + return ret;
> +
> + /*
> + * Delays are long enough, so use them for the new coming clock.
> + */
> + exynos5_switch_timing_regs(dmc, USE_MX_MSPLL_TIMINGS);
> +
> + return ret;
> +}
> +
> +/**
> + * exynos5_dmc_change_freq_and_volt() - Changes voltage and frequency of the DMC
> + * using safe procedure
> + * @dmc: device for which the frequency is going to be changed
> + * @target_rate: requested new frequency
> + * @target_volt: requested voltage which corresponds to the new frequency
> + *
> + * The DMC frequency change procedure requires a few steps.
> + * The main requirement is to change the clock source in the clk mux
> + * for the time of main clock PLL locking. The assumption is that the
> + * alternative clock source set as parent is stable.
> + * The second parent's clock frequency is fixed to 400MHz, it is named 'bypass'
> + * clock. This requires alignment in DRAM timing parameters for the new
> + * T-period. There is two bank sets for keeping DRAM
> + * timings: set 0 and set 1. The set 0 is used when main clock source is
> + * chosen. The 2nd set of regs is used for 'bypass' clock. Switching between
> + * the two bank sets is part of the process.
> + * The voltage must also be aligned to the minimum required level. There is
> + * this intermediate step with switching to 'bypass' parent clock source.
> + * if the old voltage is lower, it requires an increase of the voltage level.
> + * The complexity of the voltage manipulation is hidden in low level function.
> + * In this function there is last alignment of the voltage level at the end.
> + */
> +static int
> +exynos5_dmc_change_freq_and_volt(struct exynos5_dmc *dmc,
> + unsigned long target_rate,
> + unsigned long target_volt)
> +{
> + int ret;
> +
> + ret = exynos5_dmc_switch_to_bypass_configuration(dmc, target_rate,
> + target_volt);
> + if (ret)
> + return ret;
> +
> + /*
> + * Voltage is set at least to a level needed for this frequency,
> + * so switching clock source is safe now.
> + */
> + clk_prepare_enable(dmc->fout_spll);
> + clk_prepare_enable(dmc->mout_spll);
> + clk_prepare_enable(dmc->mout_mx_mspll_ccore);
> +
> + ret = clk_set_parent(dmc->mout_mclk_cdrex, dmc->mout_mx_mspll_ccore);
> + if (ret)
> + return ret;
> +
> + /*
> + * We are safe to increase the timings for current bypass frequency.
> + * Thanks to this the settings we be ready for the upcoming clock source
> + * change.
> + */
> + exynos5_dram_change_timings(dmc, target_rate);
> +
> + clk_set_rate(dmc->fout_bpll, target_rate);
> +
> + exynos5_switch_timing_regs(dmc, USE_BPLL_TIMINGS);
> +
> + ret = clk_set_parent(dmc->mout_mclk_cdrex, dmc->mout_bpll);
> + if (ret)
> + return ret;
> +
> + clk_disable_unprepare(dmc->mout_mx_mspll_ccore);
> + clk_disable_unprepare(dmc->mout_spll);
> + clk_disable_unprepare(dmc->fout_spll);
> + /*
> + * Make sure if the voltage is not from 'bypass' settings and align to
> + * the right level for power efficiency.
> + */
> + ret = exynos5_dmc_align_target_voltage(dmc, target_volt);
> +
> + return ret;
> +}
> +
> +/**
> + * exynos5_dmc_get_volt_freq() - Gets the frequency and voltage from the OPP
> + * table.
> + * @dev: device for which the frequency is going to be changed
> + * @freq: requested frequency in KHz
> + * @target_rate: returned frequency which is the same or lower than
> + * requested
> + * @target_volt: returned voltage which corresponds to the returned
> + * frequency
> + *
> + * Function gets requested frequency and checks OPP framework for needed
> + * frequency and voltage. It populates the values 'target_rate' and
> + * 'target_volt' or returns error value when OPP framework fails.
> + */
> +static int exynos5_dmc_get_volt_freq(struct device *dev, unsigned long *freq,
> + unsigned long *target_rate,
> + unsigned long *target_volt, u32 flags)
> +{
> + struct dev_pm_opp *opp;
> +
> + opp = devfreq_recommended_opp(dev, freq, flags);
> + if (IS_ERR(opp))
> + return PTR_ERR(opp);
> +
> + *target_rate = dev_pm_opp_get_freq(opp);
> + *target_volt = dev_pm_opp_get_voltage(opp);
> + dev_pm_opp_put(opp);
> +
> + return 0;
> +}
> +
> +/**
> + * exynos5_dmc_target() - Function responsible for changing frequency of DMC
> + * @dev: device for which the frequency is going to be changed
> + * @freq: requested frequency in KHz
> + * @flags: flags provided for this frequency change request
> + *
> + * An entry function provided to the devfreq framework which provides frequency
> + * change of the DMC. The function gets the possible rate from OPP table based
> + * on requested frequency. It calls the next function responsible for the
> + * frequency and voltage change. In case of failure, does not set 'curr_rate'
> + * and returns error value to the framework.
> + */
> +static int exynos5_dmc_target(struct device *dev, unsigned long *freq,
> + u32 flags)
> +{
> + struct exynos5_dmc *dmc = dev_get_drvdata(dev);
> + unsigned long target_rate = 0;
> + unsigned long target_volt = 0;
> + int ret;
> +
> + ret = exynos5_dmc_get_volt_freq(dev, freq, &target_rate, &target_volt,
> + flags);
> +
> + if (ret)
> + return ret;
> +
> + if (target_rate == dmc->curr_rate)
> + return 0;
> +
> + mutex_lock(&dmc->lock);
> +
> + ret = exynos5_dmc_change_freq_and_volt(dmc, target_rate, target_volt);
> +
> + if (ret) {
> + mutex_unlock(&dmc->lock);
> + return ret;
> + }
> +
> + dmc->curr_rate = target_rate;
> +
> + mutex_unlock(&dmc->lock);
> + return 0;
> +}
> +
> +/**
> + * exynos5_counters_get() - Gets the performance counters values.
> + * @dmc: device for which the counters are going to be checked
> + * @load_count: variable which is populated with counter value
> + * @total_count: variable which is used as 'wall clock' reference
> + *
> + * Function which provides performance counters values. It sums up counters for
> + * two DMC channels. The 'total_count' is used as a reference and max value.
> + * The ratio 'load_count/total_count' shows the busy percentage [0%, 100%].
> + */
> +static int exynos5_counters_get(struct exynos5_dmc *dmc,
> + unsigned long *load_count,
> + unsigned long *total_count)
> +{
> + unsigned long total = 0;
> + struct devfreq_event_data event;
> + int ret, i;
> +
> + *load_count = 0;
> +
> + /* Take into account only read+write counters, but stop all */
> + for (i = 0; i < dmc->num_counters; i++) {
> + if (!dmc->counter[i])
> + continue;
> +
> + ret = devfreq_event_get_event(dmc->counter[i], &event);
> + if (ret < 0)
> + return ret;
> +
> + if (i % 3 != 2)
> + continue;
> +
> + *load_count += event.load_count;
> +
> + if (total < event.total_count)
> + total = event.total_count;
> + }
> +
> + *total_count = total;
> +
> + return 0;
> +}
> +
> +/**
> + * exynos5_dmc_get_status() - Read current DMC performance statistics.
> + * @dev: device for which the statistics are requested
> + * @stat: structure which has statistic fields
> + *
> + * Function reads the DMC performance counters and calculates 'busy_time'
> + * and 'total_time'. To protect from overflow, the values are shifted right
> + * by 10. After read out the counters are setup to count again.
> + */
> +static int exynos5_dmc_get_status(struct device *dev,
> + struct devfreq_dev_status *stat)
> +{
> + struct exynos5_dmc *dmc = dev_get_drvdata(dev);
> + unsigned long load, total;
> + int ret;
> +
> + ret = exynos5_counters_get(dmc, &load, &total);
> + if (ret < 0)
> + return -EINVAL;
> +
> + /* To protect from overflow in calculation ratios, divide by 1024 */
> + stat->busy_time = load >> 10;
> + stat->total_time = total >> 10;
> +
> + ret = exynos5_counters_set_event(dmc);
> + if (ret < 0) {
> + dev_err(dmc->dev, "could not set event counter\n");

Please, make usage of 'dev' consistent and simpler:
1. You have here 'dev' so why dereferencing dmc->dev? Is it different dev? No.
2. In some places you use dmc->dev, in some &pdev->dev (while having
also reference to dmc). Just use one convention, except for the cases
where you could use 'dev' from argument directly.

> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +/**
> + * exynos5_dmc_get_cur_freq() - Function returns current DMC frequency
> + * @dev: device for which the framework checks operating frequency
> + * @freq: returned frequency value
> + *
> + * It returns the currently used frequency of the DMC. The real operating
> + * frequency might be lower when the clock source value could not be divided
> + * to the requested value.
> + */
> +static int exynos5_dmc_get_cur_freq(struct device *dev, unsigned long *freq)
> +{
> + struct exynos5_dmc *dmc = dev_get_drvdata(dev);
> +
> + mutex_lock(&dmc->lock);
> + *freq = dmc->curr_rate;
> + mutex_unlock(&dmc->lock);
> +
> + return 0;
> +}
> +
> +/**
> + * exynos5_dmc_df_profile - Devfreq governor's profile structure
> + *
> + * It provides to the devfreq framework needed functions and polling period.
> + */
> +static struct devfreq_dev_profile exynos5_dmc_df_profile = {
> + .polling_ms = 500,
> + .target = exynos5_dmc_target,
> + .get_dev_status = exynos5_dmc_get_status,
> + .get_cur_freq = exynos5_dmc_get_cur_freq,
> +};
> +
> +/**
> + * exynos5_dmc_align_initial_frequency() - Align initial frequency value
> + * @dmc: device for which the frequency is going to be set
> + * @bootloader_init_freq: initial frequency set by the bootloader in KHz
> + *
> + * The initial bootloader frequency, which is present during boot, might be
> + * different that supported frequency values in the driver. It is possible
> + * due to different PLL settings or used PLL as a source.
> + * This function provides the 'initial_freq' for the devfreq framework
> + * statistics engine which supports only registered values. Thus, some alignment
> + * must be made.
> + */
> +unsigned long
> +exynos5_dmc_align_init_freq(struct exynos5_dmc *dmc,
> + unsigned long bootloader_init_freq)
> +{
> + unsigned long aligned_freq;
> + int idx;
> +
> + idx = find_target_freq_idx(dmc, bootloader_init_freq);
> + if (idx >= 0)
> + aligned_freq = dmc->opp[idx].freq_hz;
> + else
> + aligned_freq = dmc->opp[dmc->opp_count - 1].freq_hz;
> +
> + return aligned_freq;
> +}
> +
> +/**
> + * create_timings_aligned() - Create register values and align with standard
> + * @dmc: device for which the frequency is going to be set
> + * @idx: speed bin in the OPP table
> + * @clk_period_ps: the period of the clock, known as tCK
> + *
> + * The function calculates timings and creates a register value ready for
> + * a frequency transition. The register contains a few timings. They are
> + * shifted by a known offset. The timing value is calculated based on memory
> + * specyfication: minimal time required and minimal cycles required.
> + */
> +static int create_timings_aligned(struct exynos5_dmc *dmc, u32 *reg_timing_row,
> + u32 *reg_timing_data, u32 *reg_timing_power,
> + u32 clk_period_ps)
> +{
> + u32 val;
> + const struct timing_reg *reg;
> +
> + if (clk_period_ps == 0)
> + return -EINVAL;
> +
> + *reg_timing_row = 0;
> + *reg_timing_data = 0;
> + *reg_timing_power = 0;
> +
> + val = dmc->timings->tRFC / clk_period_ps;
> + val += dmc->timings->tRFC % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tRFC);
> + reg = &timing_row[0];
> + *reg_timing_row |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tRRD / clk_period_ps;
> + val += dmc->timings->tRRD % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tRRD);
> + reg = &timing_row[1];
> + *reg_timing_row |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tRPab / clk_period_ps;
> + val += dmc->timings->tRPab % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tRPab);
> + reg = &timing_row[2];
> + *reg_timing_row |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tRCD / clk_period_ps;
> + val += dmc->timings->tRCD % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tRCD);
> + reg = &timing_row[3];
> + *reg_timing_row |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tRC / clk_period_ps;
> + val += dmc->timings->tRC % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tRC);
> + reg = &timing_row[4];
> + *reg_timing_row |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tRAS / clk_period_ps;
> + val += dmc->timings->tRAS % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tRAS);
> + reg = &timing_row[5];
> + *reg_timing_row |= TIMING_VAL2REG(reg, val);
> +
> + /* data related timings */
> + val = dmc->timings->tWTR / clk_period_ps;
> + val += dmc->timings->tWTR % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tWTR);
> + reg = &timing_data[0];
> + *reg_timing_data |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tWR / clk_period_ps;
> + val += dmc->timings->tWR % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tWR);
> + reg = &timing_data[1];
> + *reg_timing_data |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tRTP / clk_period_ps;
> + val += dmc->timings->tRTP % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tRTP);
> + reg = &timing_data[2];
> + *reg_timing_data |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tW2W_C2C / clk_period_ps;
> + val += dmc->timings->tW2W_C2C % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tW2W_C2C);
> + reg = &timing_data[3];
> + *reg_timing_data |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tR2R_C2C / clk_period_ps;
> + val += dmc->timings->tR2R_C2C % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tR2R_C2C);
> + reg = &timing_data[4];
> + *reg_timing_data |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tWL / clk_period_ps;
> + val += dmc->timings->tWL % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tWL);
> + reg = &timing_data[5];
> + *reg_timing_data |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tDQSCK / clk_period_ps;
> + val += dmc->timings->tDQSCK % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tDQSCK);
> + reg = &timing_data[6];
> + *reg_timing_data |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tRL / clk_period_ps;
> + val += dmc->timings->tRL % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tRL);
> + reg = &timing_data[7];
> + *reg_timing_data |= TIMING_VAL2REG(reg, val);
> +
> + /* power related timings */
> + val = dmc->timings->tFAW / clk_period_ps;
> + val += dmc->timings->tFAW % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tXP);
> + reg = &timing_power[0];
> + *reg_timing_power |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tXSR / clk_period_ps;
> + val += dmc->timings->tXSR % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tXSR);
> + reg = &timing_power[1];
> + *reg_timing_power |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tXP / clk_period_ps;
> + val += dmc->timings->tXP % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tXP);
> + reg = &timing_power[2];
> + *reg_timing_power |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tCKE / clk_period_ps;
> + val += dmc->timings->tCKE % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tCKE);
> + reg = &timing_power[3];
> + *reg_timing_power |= TIMING_VAL2REG(reg, val);
> +
> + val = dmc->timings->tMRD / clk_period_ps;
> + val += dmc->timings->tMRD % clk_period_ps ? 1 : 0;
> + val = max(val, dmc->min_tck->tMRD);
> + reg = &timing_power[4];
> + *reg_timing_power |= TIMING_VAL2REG(reg, val);
> +
> + return 0;
> +}
> +
> +/**
> + * of_get_dram_timings() - helper function for parsing DT settings for DRAM
> + * @dmc: device for which the frequency is going to be set
> + *
> + * The function parses DT entries with DRAM information.
> + */
> +static int of_get_dram_timings(struct exynos5_dmc *dmc)
> +{
> + int ret = 0;
> + int idx;
> + struct device_node *np_ddr;
> + u32 freq_mhz, clk_period_ps;
> +
> + np_ddr = of_parse_phandle(dmc->dev->of_node, "device-handle", 0);
> + if (!np_ddr) {
> + dev_warn(dmc->dev, "could not find 'device-handle' in DT\n");
> + return -EINVAL;
> + }
> +
> + dmc->timing_row = devm_kmalloc_array(dmc->dev, TIMING_COUNT,
> + sizeof(u32), GFP_KERNEL);
> + if (!dmc->timing_row)
> + return -ENOMEM;
> +
> + dmc->timing_data = devm_kmalloc_array(dmc->dev, TIMING_COUNT,
> + sizeof(u32), GFP_KERNEL);
> + if (!dmc->timing_data)
> + return -ENOMEM;
> +
> + dmc->timing_power = devm_kmalloc_array(dmc->dev, TIMING_COUNT,
> + sizeof(u32), GFP_KERNEL);
> + if (!dmc->timing_power)
> + return -ENOMEM;
> +
> + dmc->timings = of_lpddr3_get_ddr_timings(np_ddr, dmc->dev,
> + DDR_TYPE_LPDDR3,
> + &dmc->timings_arr_size);
> + if (!dmc->timings) {
> + of_node_put(np_ddr);
> + dev_warn(dmc->dev, "could not get timings from DT\n");
> + return -EINVAL;
> + }
> +
> + dmc->min_tck = of_lpddr3_get_min_tck(np_ddr, dmc->dev);
> + if (!dmc->min_tck) {
> + of_node_put(np_ddr);
> + dev_warn(dmc->dev, "could not get tck from DT\n");
> + return -EINVAL;
> + }
> +
> + /* Sorted array of OPPs with frequency ascending */
> + for (idx = 0; idx < dmc->opp_count; idx++) {
> + freq_mhz = dmc->opp[idx].freq_hz / 1000000;
> + clk_period_ps = 1000000 / freq_mhz;
> +
> + ret = create_timings_aligned(dmc, &dmc->timing_row[idx],
> + &dmc->timing_data[idx],
> + &dmc->timing_power[idx],
> + clk_period_ps);
> + }
> +
> + of_node_put(np_ddr);
> +
> + /* Take the highest frequency's timings as 'bypass' */
> + dmc->bypass_timing_row = dmc->timing_row[idx - 1];
> + dmc->bypass_timing_data = dmc->timing_data[idx - 1];
> + dmc->bypass_timing_power = dmc->timing_power[idx - 1];
> +
> + return ret;
> +}
> +
> +/**
> + * exynos5_dmc_init_clks() - Initialize clocks needed for DMC operation.
> + * @dev: device for which the clocks are setup
> + * @dmc: DMC structure containing needed fields
> + *
> + * Get the needed clocks defined in DT device, enable and set the right parents.
> + * Read current frequency and initialize the initial rate for governor.
> + */
> +static int exynos5_dmc_init_clks(struct device *dev, struct exynos5_dmc *dmc)
> +{
> + int ret;
> + unsigned long target_volt = 0;
> + unsigned long target_rate = 0;
> +
> + dmc->fout_spll = devm_clk_get(dev, "fout_spll");
> + if (IS_ERR(dmc->fout_spll))
> + return PTR_ERR(dmc->fout_spll);
> +
> + dmc->fout_bpll = devm_clk_get(dev, "fout_bpll");
> + if (IS_ERR(dmc->fout_bpll))
> + return PTR_ERR(dmc->fout_bpll);
> +
> + dmc->mout_mclk_cdrex = devm_clk_get(dev, "mout_mclk_cdrex");
> + if (IS_ERR(dmc->mout_mclk_cdrex))
> + return PTR_ERR(dmc->mout_mclk_cdrex);
> +
> + dmc->mout_bpll = devm_clk_get(dev, "mout_bpll");
> + if (IS_ERR(dmc->mout_bpll))
> + return PTR_ERR(dmc->mout_bpll);
> +
> + dmc->mout_mx_mspll_ccore = devm_clk_get(dev, "mout_mx_mspll_ccore");
> + if (IS_ERR(dmc->mout_mx_mspll_ccore))
> + return PTR_ERR(dmc->mout_mx_mspll_ccore);
> +
> + dmc->dout_clk2x_phy0 = devm_clk_get(dev, "dout_clk2x_phy0");
> + if (IS_ERR(dmc->dout_clk2x_phy0))
> + return PTR_ERR(dmc->dout_clk2x_phy0);
> +
> + dmc->mout_spll = devm_clk_get(dev, "ff_dout_spll2");
> + if (IS_ERR(dmc->mout_spll)) {
> + dmc->mout_spll = devm_clk_get(dev, "mout_sclk_spll");
> + if (IS_ERR(dmc->mout_spll))
> + return PTR_ERR(dmc->mout_spll);
> + }
> +
> + /*
> + * Convert frequency to KHz values and set it for the governor.
> + */
> + dmc->curr_rate = clk_get_rate(dmc->mout_mclk_cdrex);
> + dmc->curr_rate = exynos5_dmc_align_init_freq(dmc, dmc->curr_rate);
> + exynos5_dmc_df_profile.initial_freq = dmc->curr_rate;
> +
> + ret = exynos5_dmc_get_volt_freq(dev, &dmc->curr_rate, &target_rate,
> + &target_volt, 0);
> + if (ret)
> + return ret;
> +
> + dmc->curr_volt = target_volt;
> +
> + clk_prepare_enable(dmc->mout_spll);
> + clk_set_parent(dmc->mout_mx_mspll_ccore, dmc->mout_spll);
> + clk_prepare_enable(dmc->mout_mx_mspll_ccore);
> +
> + dmc->bypass_rate = clk_get_rate(dmc->mout_mx_mspll_ccore);
> +
> + clk_prepare_enable(dmc->fout_bpll);
> + clk_prepare_enable(dmc->mout_bpll);
> +

This would leave certain clocks unbalanced (e.g. mout_spll). I do not
get logic of it... you enable them for entire lifetime of device and
then still toggle in exynos5_dmc_change_freq_and_volt(). Which clocks
do you want to have enabled all the time and which not?


> + return 0;
> +}
> +
> +/**
> + * exynos5_performance_counters_init() - Initializes performance DMC's counters
> + * @dmc: DMC for which it does the setup
> + *
> + * Initialization of performance counters in DMC for estimating usage.
> + * The counter's values are used for calculation of a memory bandwidth and based
> + * on that the governor changes the frequency.
> + * The counters are not used when the governor is GOVERNOR_USERSPACE.
> + */
> +static int exynos5_performance_counters_init(struct exynos5_dmc *dmc)
> +{
> + int counters_size;
> + int ret, i;
> +
> + dmc->num_counters = devfreq_event_get_edev_count(dmc->dev);
> + if (dmc->num_counters < 0) {
> + dev_err(dmc->dev, "could not get devfreq-event counters\n");
> + return dmc->num_counters;
> + }
> +
> + counters_size = sizeof(struct devfreq_event_dev) * dmc->num_counters;
> + dmc->counter = devm_kzalloc(dmc->dev, counters_size, GFP_KERNEL);
> + if (!dmc->counter)
> + return -ENOMEM;
> +
> + for (i = 0; i < dmc->num_counters; i++) {
> + dmc->counter[i] =
> + devfreq_event_get_edev_by_phandle(dmc->dev, i);
> + if (IS_ERR_OR_NULL(dmc->counter[i]))
> + return -EPROBE_DEFER;
> + }
> +
> + ret = exynos5_counters_enable_edev(dmc);
> + if (ret < 0) {
> + dev_err(dmc->dev, "could not enable event counter\n");
> + return ret;
> + }
> +
> + ret = exynos5_counters_set_event(dmc);
> + if (ret < 0) {
> + dev_err(dmc->dev, "counld not set event counter\n");
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +#ifdef CONFIG_DEBUG_FS
> +
> +static int dmc_dbg_show_timings(struct seq_file *seq, void *na)
> +{
> + struct exynos5_dmc *dmc = seq->private;
> + int i, j;
> + u32 val;
> + const struct timing_reg *reg;
> +
> + seq_printf(seq, "timings for each frequency\n");
> + for (j = dmc->opp_count - 1; j >= 0; j--) {
> + seq_printf(seq, "frequency = %uMHz\n",
> + dmc->opp[j].freq_hz / 1000000);
> + seq_printf(seq, "timing_row, timing_data, timing_power\n");
> + seq_printf(seq, "0x%08X, 0x%08X, 0x%08X\n", dmc->timing_row[j],
> + dmc->timing_data[j], dmc->timing_power[j]);
> + }
> +
> + for (j = dmc->opp_count - 1; j >= 0; j--) {
> + seq_printf(seq, "frequency [MHz] = %u\n",
> + dmc->opp[j].freq_hz / 1000000);
> +
> + for (i = 0; i < ARRAY_SIZE(timing_row); i++) {
> + reg = &timing_row[i];
> + val = TIMING_REG2VAL(dmc->timing_row[j], reg);
> + seq_printf(seq, "%s = %u\n", reg->name, val);
> + }
> +
> + for (i = 0; i < ARRAY_SIZE(timing_data); i++) {
> + reg = &timing_data[i];
> + val = TIMING_REG2VAL(dmc->timing_data[j], reg);
> + seq_printf(seq, "%s = %u\n", reg->name, val);
> + }
> +
> + for (i = 0; i < ARRAY_SIZE(timing_power); i++) {
> + reg = &timing_power[i];
> + val = TIMING_REG2VAL(dmc->timing_power[j], reg);
> + seq_printf(seq, "%s = %u\n", reg->name, val);
> + }
> + }
> +
> + return 0;
> +}
> +
> +static int dmc_dbg_open_timings(struct inode *inode, struct file *f)
> +{
> + return single_open(f, dmc_dbg_show_timings, inode->i_private);
> +}
> +
> +static const char *event_get_name(const char *evt)
> +{
> + int i;
> +
> + for (i = 0; i < ARRAY_SIZE(event_name); i += 2) {
> + if (!strcmp(event_name[i], evt))
> + return event_name[i + 1];
> + }
> +
> + return "Unknown";
> +}
> +
> +static int dmc_dbg_show_cnt(struct seq_file *seq, void *na)
> +{
> + struct exynos5_dmc *dmc = seq->private;
> + int i;
> + struct devfreq_event_data event;
> + struct devfreq_event_dev *edev;
> + int ret;
> + const char *evt_name;
> + u64 ts_new, delta;
> + static u64 ts;
> +
> + seq_printf(seq, "Performance based on PMU counters\n");
> + seq_printf(seq, "The counters could overflow every ~9.2 sec\n");
> +
> + ts_new = ktime_get_ns();
> + delta = ts_new - ts;
> +
> + for (i = 0; i < dmc->num_counters; i++) {
> + edev = dmc->counter[i];
> + if (!edev)
> + continue;
> +
> + evt_name = event_get_name(edev->desc->name);
> +
> + ret = devfreq_event_get_event(edev, &event);
> + if (ret < 0)
> + return ret;
> +
> + seq_printf(seq, "%s = %lu / %lu\n", evt_name, event.load_count,
> + event.total_count);
> + }
> +
> + seq_printf(seq, "For last %llu ms\n",
> + div64_u64(delta, 1000000UL));
> +
> + ts = ktime_get_ns();
> + ret = exynos5_counters_set_event(dmc);
> + if (ret < 0) {
> + dev_err(dmc->dev, "could not set event counter\n");
> + return ret;
> + }
> +
> + return 0;
> +}
> +
> +static int dmc_dbg_open_cnt(struct inode *inode, struct file *f)
> +{
> + return single_open(f, dmc_dbg_show_cnt, inode->i_private);
> +}
> +
> +struct counter {
> + u64 load;
> + u64 total;
> +};
> +
> +static int dmc_dbg_show_cnt_100ms(struct seq_file *seq, void *na)
> +{
> + struct exynos5_dmc *dmc = seq->private;
> + int i;
> + u64 bandwidth = 0;
> + struct devfreq_event_data event;
> + struct devfreq_event_dev *edev;
> + int ret;
> + const char *evt_name;
> + u64 ts_new, delta;
> + static u64 ts;
> + struct counter *cnt;
> + u64 total[3] = {0, 0, 0 }; /* read, write, read+write data*/
> + const char *type[3] = {"read", "write", "read+write"};
> + u64 bus_cyc_count = 0;
> + int offset = 0;
> + char *s;

That amount of local declarations is a clear hint that you should
split this function.

> +
> + s = kzalloc(PAGE_SIZE * sizeof(char), GFP_KERNEL);
> + if (!s)
> + return -ENOMEM;
> +
> + cnt = kcalloc(dmc->num_counters, sizeof(struct counter), GFP_KERNEL);
> + if (!cnt)
> + return -ENOMEM;
> +
> + ret = exynos5_counters_set_event(dmc);
> + if (ret < 0) {
> + dev_err(dmc->dev, "could not set event counter\n");
> + return ret;
> + }
> +
> + ts = ktime_get_ns();
> + msleep(100);
> +
> + /* Seprate data acquisition from presentation due to some
> + overheads. */
> + for (i = 0; i < dmc->num_counters; i++) {
> + edev = dmc->counter[i];
> + if (!edev)
> + continue;
> +
> + ret = devfreq_event_get_event(edev, &event);
> + if (ret < 0)
> + return ret;
> +
> + total[i % 3] += event.load_count;
> + cnt[i].load = event.load_count;
> + cnt[i].total = event.total_count;
> +
> + if (bus_cyc_count < event.total_count)
> + bus_cyc_count = event.total_count;
> + }
> +
> + ts_new = ktime_get_ns();
> + delta = ts_new - ts;
> + if (delta == 0)
> + delta = 1;
> +
> + for (i = 0; i < dmc->num_counters; i++) {
> + edev = dmc->counter[i];
> + if (!edev)
> + continue;
> +
> + evt_name = event_get_name(edev->desc->name);
> +
> + bandwidth = (u64)cnt[i].load * AXI_BUS_WIDTH_BYTES * 1000;
> + bandwidth = div64_u64(bandwidth, delta);
> +
> + offset += sprintf(s + offset, "%s\t\t%llu MB/s\n",
> + evt_name, bandwidth);
> + }
> +
> + for (i = 0; i < 3; i++) {
> + bandwidth = (u64)total[i] * AXI_BUS_WIDTH_BYTES * 1000;
> + bandwidth = div64_u64(bandwidth, delta);
> +
> + offset += sprintf(s + offset, "total\t%s\t\t%llu MB/s\n",
> + type[i], bandwidth);
> + }
> +
> + /* AXI speed is presented in MHz*/
> + bus_cyc_count *= 1000;
> +
> + seq_printf(seq, "Performance based on PMU counters\n");
> + seq_printf(seq, "The counters will overflow every ~9.2 sec\n");
> + seq_printf(seq, "%s", s);
> + seq_printf(seq, "AXI bus frequency %llu MHz, width %u B, SDR mode\n",
> + div64_u64(bus_cyc_count, delta), AXI_BUS_WIDTH_BYTES);
> + seq_printf(seq, "For last %llu ms\n",
> + div64_u64(delta, 1000000UL));
> +
> + kfree(cnt);
> + kfree(s);
> +
> + return 0;
> +}
> +
> +static int dmc_dbg_show_cnt_100ms_raw(struct seq_file *seq, void *na)
> +{
> + struct exynos5_dmc *dmc = seq->private;
> + int i;
> + struct devfreq_event_data event;
> + struct devfreq_event_dev *edev;
> + int ret;
> + const char *evt_name;
> + u64 ts_new, delta;
> + static u64 ts;
> + struct counter *cnt;
> + const char *type[3] = {"read", "write", "read+write"};
> + int offset = 0;
> + char *s;

The same.

> +
> + s = kzalloc(PAGE_SIZE * sizeof(char), GFP_KERNEL);
> + if (!s)
> + return -ENOMEM;
> +
> + cnt = kcalloc(dmc->num_counters, sizeof(struct counter), GFP_KERNEL);
> + if (!cnt)
> + return -ENOMEM;
> +
> + ret = exynos5_counters_set_event(dmc);
> + if (ret < 0) {
> + dev_err(dmc->dev, "could not set event counter\n");
> + return ret;
> + }
> +
> + ts = ktime_get_ns();
> + msleep(100);
> +
> + /* Seprate data acquisition from presentation due to some
> + overheads. */
> + for (i = 0; i < dmc->num_counters; i++) {
> + edev = dmc->counter[i];
> + if (!edev)
> + continue;
> +
> + ret = devfreq_event_get_event(edev, &event);
> + if (ret < 0)
> + return ret;
> +
> + cnt[i].load = event.load_count;
> + cnt[i].total = event.total_count;
> + }
> +
> + ts_new = ktime_get_ns();
> + delta = ts_new - ts;
> + if (delta == 0)
> + delta = 1;
> +
> + for (i = 0; i < dmc->num_counters; i++) {
> + edev = dmc->counter[i];
> + if (!edev)
> + continue;
> +
> + evt_name = event_get_name(edev->desc->name);
> +
> + offset += sprintf(s + offset, "%s (%s)\t\t%llu / %llu\n",
> + evt_name, type[i % 3], cnt[i].load,
> + cnt[i].total);
> + }
> +
> + seq_printf(seq, "Performance based on PMU counters ('load'/'total')\n");
> + seq_printf(seq, "The counters will overflow every ~9.2 sec\n");
> + seq_printf(seq, "%s", s);
> + seq_printf(seq, "For last %llu ms\n",
> + div64_u64(delta, 1000000UL));
> +
> + kfree(cnt);
> + kfree(s);
> +
> + return 0;
> +}
> +
> +static int dmc_dbg_open_cnt_100ms(struct inode *inode, struct file *f)
> +{
> + return single_open(f, dmc_dbg_show_cnt_100ms, inode->i_private);
> +}
> +
> +static int dmc_dbg_open_cnt_100ms_raw(struct inode *inode, struct file *f)
> +{
> + return single_open(f, dmc_dbg_show_cnt_100ms_raw, inode->i_private);
> +}
> +
> +static const struct file_operations dmc_debugfs_ops_timings = {
> + .open = dmc_dbg_open_timings,
> + .read = seq_read,
> + .release = single_release,
> +};
> +
> +static const struct file_operations dmc_debugfs_ops_cnt = {
> + .open = dmc_dbg_open_cnt,
> + .read = seq_read,
> + .release = single_release,
> +};
> +
> +static const struct file_operations dmc_debugfs_ops_cnt_100ms = {
> + .open = dmc_dbg_open_cnt_100ms,
> + .read = seq_read,
> + .release = single_release,
> +};
> +
> +static const struct file_operations dmc_debugfs_ops_cnt_100ms_raw = {
> + .open = dmc_dbg_open_cnt_100ms_raw,
> + .read = seq_read,
> + .release = single_release,
> +};
> +
> +static void exynos5_dmc_debugfs_init(struct exynos5_dmc *dmc)
> +{
> + struct dentry *dentry;
> +
> + dmc->dbg_root = debugfs_create_dir(dev_name(dmc->dev), NULL);
> + if (!dmc->dbg_root)
> + return;
> +
> + dentry = debugfs_create_file("timings", 0444, dmc->dbg_root, dmc,
> + &dmc_debugfs_ops_timings);
> + if (!dentry)
> + goto clean_debugfs;
> +
> + dentry = debugfs_create_file("counters", 0444, dmc->dbg_root, dmc,
> + &dmc_debugfs_ops_cnt);
> + if (!dentry)
> + goto clean_debugfs;
> +
> + dentry = debugfs_create_file("100ms_counters", 0444, dmc->dbg_root, dmc,
> + &dmc_debugfs_ops_cnt_100ms);
> + if (!dentry)
> + goto clean_debugfs;
> +
> + dentry = debugfs_create_file("100ms_raw_counters", 0444, dmc->dbg_root,
> + dmc, &dmc_debugfs_ops_cnt_100ms_raw);
> + if (!dentry)
> + goto clean_debugfs;
> +
> + return;
> +
> +clean_debugfs:
> + debugfs_remove_recursive(dmc->dbg_root);
> +}
> +#else
> +static void exynos5_dmc_debugfs_init(struct exynos5_dmc *dmc)
> +{}
> +#endif
> +
> +/**
> + * exynos5_dmc_set_pause_on_switching() - Controls a pause feature in DMC
> + * @dmc: device which is used for changing this feature
> + * @set: a boolean state passing enable/disable request
> + *
> + * There is a need of pausing DREX DMC when divider or MUX in clock tree
> + * changes its configuration. In such situation access to the memory is blocked
> + * in DMC automatically. This feature is used when clock frequency change
> + * request appears and touches clock tree.
> + */
> +static inline int exynos5_dmc_set_pause_on_switching(struct exynos5_dmc *dmc)
> +{
> + unsigned int val;
> + int ret;
> +
> + ret = regmap_read(dmc->clk_regmap, CDREX_PAUSE, &val);
> + if (ret)
> + return ret;
> +
> + val |= 1UL;
> + regmap_write(dmc->clk_regmap, CDREX_PAUSE, val);
> +
> + return 0;
> +}
> +
> +/**
> + * exynos5_dmc_probe() - Probe function for the DMC driver
> + * @pdev: platform device for which the driver is going to be initialized
> + *
> + * Initialize basic components: clocks, regulators, performance counters, etc.
> + * Read out product version and based on the information setup
> + * internal structures for the controller (frequency and voltage) and for DRAM
> + * memory parameters: timings for each operating frequency.
> + * Register new devfreq device for controlling DVFS of the DMC.
> + */
> +static int exynos5_dmc_probe(struct platform_device *pdev)
> +{
> + int ret = 0;
> + struct exynos5_dmc *dmc;
> + struct device *dev = &pdev->dev;
> + struct device_node *np = dev->of_node;
> + struct resource *res;
> +
> + dmc = devm_kzalloc(dev, sizeof(*dmc), GFP_KERNEL);
> + if (!dmc)
> + return -ENOMEM;
> +
> + mutex_init(&dmc->lock);
> +
> + dmc->dev = dev;
> + platform_set_drvdata(pdev, dmc);
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + dmc->base_drexi0 = devm_ioremap_resource(dev, res);
> + if (IS_ERR(dmc->base_drexi0))
> + return PTR_ERR(dmc->base_drexi0);
> +
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> + dmc->base_drexi1 = devm_ioremap_resource(dev, res);
> + if (IS_ERR(dmc->base_drexi1))
> + return PTR_ERR(dmc->base_drexi1);
> +
> + dmc->chipid_regmap = syscon_regmap_lookup_by_phandle(np,
> + "samsung,syscon-chipid");
> + if (IS_ERR(dmc->chipid_regmap))
> + return PTR_ERR(dmc->chipid_regmap);
> +
> + dmc->clk_regmap = syscon_regmap_lookup_by_phandle(np,
> + "samsung,syscon-clk");
> + if (IS_ERR(dmc->clk_regmap))
> + return PTR_ERR(dmc->clk_regmap);
> +
> + ret = exynos5_dmc_chip_revision_settings(dmc);
> + if (ret)
> + return ret;
> +
> + ret = exynos5_init_freq_table(dev, dmc, &exynos5_dmc_df_profile);
> + if (ret) {
> + dev_warn(dev, "couldn't initialize frequency settings\n");
> + return ret;
> + }
> +
> + dmc->vdd_mif = devm_regulator_get(dev, "vdd");
> + if (IS_ERR(dmc->vdd_mif)) {
> + ret = PTR_ERR(dmc->vdd_mif);
> + dev_warn(dev, "couldn't get regulator\n");

This could be EPROBE_DEFER so do not print a warning then.

> + return ret;
> + }
> +
> + ret = exynos5_dmc_init_clks(dev, dmc);
> + if (ret) {
> + dev_warn(dev, "couldn't initialize clocks\n");

The same - no warnings on deferred probe.

> + return ret;
> + }
> +
> + ret = of_get_dram_timings(dmc);
> + if (ret) {
> + dev_warn(dev, "couldn't initialize timings settings\n");
> + return ret;
> + }
> +
> + ret = exynos5_performance_counters_init(dmc);
> + if (ret) {
> + dev_warn(dev, "couldn't probe performance counters\n");
> + goto remove_clocks;
> + }
> +
> + ret = exynos5_dmc_set_pause_on_switching(dmc);
> + if (ret) {
> + dev_warn(dev, "couldn't get access to PAUSE register\n");
> + goto remove_clocks;
> + }
> +

One line can be removed.

> +
> + /*
> + * Setup default thresholds for the devfreq governor.
> + * The values are chosen based on experiments.
> + */
> + dmc->gov_data.upthreshold = 30;
> + dmc->gov_data.downdifferential = 5;
> +
> + dmc->df = devm_devfreq_add_device(dev, &exynos5_dmc_df_profile,
> + DEVFREQ_GOV_USERSPACE,
> + &dmc->gov_data);
> +
> + if (IS_ERR(dmc->df)) {
> + ret = PTR_ERR(dmc->df);
> + goto err_devfreq_add;
> + }
> +
> + exynos5_dmc_debugfs_init(dmc);
> +
> + dev_info(&pdev->dev, "DMC init for prod_id=0x%08x pkg_id=0x%08x\n",
> + dmc->prod_rev, dmc->pkg_rev);
> +
> + return 0;
> +
> +err_devfreq_add:
> + exynos5_counters_disable_edev(dmc);
> +remove_clocks:
> + clk_disable_unprepare(dmc->mout_mx_mspll_ccore);
> + clk_disable_unprepare(dmc->mout_spll);

It does not look like full clock cleanup. You enabled 4 clocks.

> +
> + return ret;
> +}
> +
> +/**
> + * exynos5_dmc_remove() - Remove function for the platform device
> + * @pdev: platform device which is going to be removed
> + *
> + * The function relies on 'devm' framework function which automatically
> + * clean the device's resources. It just calls explicitly disable function for
> + * the performance counters.
> + */
> +static int exynos5_dmc_remove(struct platform_device *pdev)
> +{
> + struct exynos5_dmc *dmc = dev_get_drvdata(&pdev->dev);
> +
> + exynos5_counters_disable_edev(dmc);
> +
> + clk_disable_unprepare(dmc->mout_mx_mspll_ccore);
> + clk_disable_unprepare(dmc->mout_spll);

The same.

> +
> + dev_pm_opp_remove_table(&pdev->dev);
> +
> + dev_info(&pdev->dev, "DMC removed\n");

No need to inform about removal.

Best regards,
Krzysztof

> +
> + return 0;
> +}
> +
> +static const struct of_device_id exynos5_dmc_of_match[] = {
> + { .compatible = "samsung,exynos5422-dmc", },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, exynos5_dmc_of_match);
> +
> +static struct platform_driver exynos5_dmc_platdrv = {
> + .probe = exynos5_dmc_probe,
> + .remove = exynos5_dmc_remove,
> + .driver = {
> + .name = "exynos5-dmc",
> + .of_match_table = exynos5_dmc_of_match,
> + },
> +};
> +module_platform_driver(exynos5_dmc_platdrv);
> +MODULE_DESCRIPTION("Driver for Exynos5422 Dynamic Memory Controller dynamic frequency and voltage change");
> +MODULE_LICENSE("GPL v2");
> +MODULE_AUTHOR("Samsung");
> --
> 2.7.4
>