Re: [PATCH v4 02/10] dt-bindings: doc: reflect new NVMEM of_get_mac_address behaviour

From: Petr Åtetiar
Date: Wed May 08 2019 - 04:42:57 EST


Rob Herring <robh+dt@xxxxxxxxxx> [2019-05-07 11:44:57]:

Hi,

> > -- local-mac-address: the driver is designed to use the of_get_mac_address api
> > - only if efuse-mac is 0. When efuse-mac is 0, the MAC
> > - address is obtained from local-mac-address. If this
> > - attribute is not present, then the driver will use a
> > - random MAC address.
> > - "netcp-device label": phandle to the device specification for each of NetCP
> > sub-module attached to this interface.
> >
> > +The MAC address will be determined using the optional properties defined in
> > +ethernet.txt, as provided by the of_get_mac_address API and only if efuse-mac
>
> Don't make references to Linux in bindings. You can talk about
> expectations of client programs (e.g Linux, u-boot, BSD, etc.) though.

I've just tried to reword what was already there, anyway, did I understood
your remark properly, would this be more appropriate?

The MAC address will be determined using the optional properties defined in
ethernet.txt and only if efuse-mac is set to 0. If any of the optional MAC
address properties are not present, then the driver will use random MAC
address.

Thanks!

-- ynezz