[PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h
From: Paul Gortmaker
Date: Sat Apr 13 2019 - 11:15:18 EST
This file is implicitly relying on an instance of including
module.h from <linux/acpi.h>.
Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.
The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
Here, we make the include explicit, in order to allow the future
removal of module.h from linux/acpi.h without causing build breakage.
Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>
Cc: Mark Brown <broonie@xxxxxxxxxx>
Cc: Jaroslav Kysela <perex@xxxxxxxx>
Cc: Takashi Iwai <tiwai@xxxxxxxx>
Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
sound/soc/soc-acpi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c
index 4fb29f0e561e..444ce0602f76 100644
@@ -4,6 +4,8 @@
// Copyright (c) 2013-15, Intel Corporation.
struct snd_soc_acpi_mach *