Re: [PATCH 4/7] sched: Add sched_load_rq tracepoint
From: Qais Yousef
Date: Wed May 08 2019 - 09:39:25 EST
On 05/06/19 11:18, Peter Zijlstra wrote:
> On Mon, May 06, 2019 at 11:08:59AM +0200, Peter Zijlstra wrote:
> > Also; I _really_ hate how fat they are. Why can't we do simple straight
> > forward things like:
> > trace_pelt_cfq(cfq);
> > trace_pelt_rq(rq);
> > trace_pelt_se(se);
> > And then have the thing attached to the event do the fat bits like
> > extract the path and whatnot.
> ARGH, because we don't export any of those data structures (for good
> reason).. bah I hate all this.
I am not a big fan either..
FWIW struct sched_entity and struct sched_avg are exported but only used in
kernel/sched/*. Are the reasons behind not exporting struct cfs_rq and struct
rq are really different to the other 2?
Anyways. I have v2 almost ready but thought I'd ask before posting if we want
to handle this in a different way.