Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs
From: Evan Green
Date: Wed May 08 2019 - 12:44:31 EST
On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart
> Minor nit-picks below. The Kconfig would work but select CANNONLAKE even
> if you don't want it.
> > +config SND_SOC_SOF_COMETLAKE_LP
> > + tristate
> > + select SND_SOC_SOF_CANNONLAKE
> This should be
> select SND_SOF_SOF_HDA_COMMON
You mean SND_SOC_SOF_HDA_COMMON I assume.
Except that I also need &cnl_desc, so I need CANNONLAKE to be on as
well. Should I select them both?