Re: [PATCH v2] checkpatch: add command-line option for TAB size
From: Antonio Borneo
Date: Wed May 08 2019 - 14:21:10 EST
On Wed, May 8, 2019 at 7:56 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Wed, 2019-05-08 at 19:43 +0200, Antonio Borneo wrote:
> > The size of 8 characters used for both TAB and indentation is
> > embedded as magic value allover the checkpatch script, and this
> > makes the script less readable.
> I doubt this bit of the commit message is proper.
> Tabs _are_ 8 in the linux-kernel sources and checkpatch
> was written for the linux-kernel.
> Using a variable _could_ reasonably be described as an
> improvement, but readability wasn't and isn't really an
> issue here.
Well, it depends on own skill with regular expressions in perl :-)
I will change the commit message focusing on the new command line flag
and drop this part.