Re: [PATCH] i915: disable framebuffer compression on GeminiLake
From: Jani Nikula
Date: Thu May 09 2019 - 08:32:20 EST
On Thu, 09 May 2019, Daniel Drake <drake@xxxxxxxxxxxx> wrote:
> On Thu, Apr 25, 2019 at 4:27 AM Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> wrote:
>> Em qua, 2019-04-24 Ãs 20:58 +0100, Chris Wilson escreveu:
>> > Quoting Jian-Hong Pan (2019-04-23 10:28:10)
>> > > From: Daniel Drake <drake@xxxxxxxxxxxx>
>> > >
>> > > On many (all?) the Gemini Lake systems we work with, there is frequent
>> > > momentary graphical corruption at the top of the screen, and it seems
>> > > that disabling framebuffer compression can avoid this.
>> > >
>> > > The ticket was reported 6 months ago and has already affected a
>> > > multitude of users, without any real progress being made. So, lets
>> > > disable framebuffer compression on GeminiLake until a solution is found.
>> > >
>> > > Buglink: https://bugs.freedesktop.org/show_bug.cgi?id=108085
>> > > Signed-off-by: Daniel Drake <drake@xxxxxxxxxxxx>
>> > > Signed-off-by: Jian-Hong Pan <jian-hong@xxxxxxxxxxxx>
>> > Fixes: fd7d6c5c8f3e ("drm/i915: enable FBC on gen9+ too") ?
>> > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
>> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
>> > Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
>> > Cc: <stable@xxxxxxxxxxxxxxx> # v4.11+
>> > glk landed 1 month before, so that seems the earliest broken point.
>> The bug is well reported, the bug author is helpful and it even has a
>> description of "steps to reproduce" that looks very easy (although I
>> didn't try it). Everything suggests this is a bug the display team
>> could actually solve with not-so-many hours of debugging.
>> In the meantime, unbreak the systems:
>> Reviewed-by: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx>
> Quick ping here. Any further comments on this patch? Can it be applied?
Pushed now, thanks. Needed to get a clean CI result, and I dropped the
ball a bit there, sorry.
Jani Nikula, Intel Open Source Graphics Center