Re: [PATCH 3/3] hwrng: add mt67xx-rng driver
From: Neal Liu
Date: Thu May 09 2019 - 10:56:06 EST
On Thu, 2019-05-09 at 13:26 +0800, Herbert Xu wrote:
> On Wed, May 08, 2019 at 06:35:37PM +0800, Neal Liu wrote:
> > Hi Stephan,
> > We think the cast is fine, and it cannot guarantee the buf is
> > word-align.
> > I reference multiple rng driver's implementation and found it's common
> > usage for this. So it might be general usage for community. Is there any
> > suggestion that is more appropriate?
> If you don't know whether it's unaligned or not then you should
> do an unaligned operation.
My mistake. This buffer is allocated by kmalloc with larger than 32
bytes. So yes, it's word-align for sure.