Re: [PATCH 02/10] PCI/PME: Replace dev_printk(KERN_DEBUG) with dev_info()
From: Andy Shevchenko
Date: Thu May 09 2019 - 13:36:31 EST
On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
> Replace dev_printk(KERN_DEBUG) with dev_info() or dev_err() to be more
> consistent with other logging.
> These could be converted to dev_dbg(), but that depends on
> CONFIG_DYNAMIC_DEBUG and DEBUG, and we want most of these messages to
> *always* be in the dmesg log.
> Also, use dev_fmt() to add the service name. Example output change:
> - pcieport 0000:80:10.0: Signaling PME with IRQ ...
> + pcieport 0000:80:10.0: PME: Signaling with IRQ ...
> + pci_info(port, "interrupt generated for non-existent device %02x:%02x.%d\n",
Can we be slightly more consistent here, i.e. start from Capital letter?
> + busnr, PCI_SLOT(devfn), PCI_FUNC(devfn));
> + pci_info(port, "Spurious native interrupt!\n");
> + pci_info(port, "Signaling with IRQ %d\n", srv->irq);
With Best Regards,