RE: [EXT] [PATCH 4.19 60/66] scsi: qla2xxx: Fix device staying in blocked state

From: Quoc Tran
Date: Thu May 09 2019 - 16:29:53 EST

Hi All,

Please, remove Quoc Tran (qtran@xxxxxxxxxxx) from this email. I think the correct contact is Quinn Tran (qutran@xxxxxxxxxxx)


-----Original Message-----
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Sent: Thursday, May 9, 2019 11:43 AM
To: linux-kernel@xxxxxxxxxxxxxxx
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx; Quoc Tran <qtran@xxxxxxxxxxx>; Himanshu Madhani <hmadhani@xxxxxxxxxxx>; Ewan D. Milne <emilne@xxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Subject: [EXT] [PATCH 4.19 60/66] scsi: qla2xxx: Fix device staying in blocked state

External Email

From: Quinn Tran <qtran@xxxxxxxxxxx>

commit 2137490f2147a8d0799b72b9a1023efb012d40c7 upstream.

This patch fixes issue reported by some of the customers, who discovered that after cable pull scenario the devices disappear and path seems to remain in blocked state. Once the device reappears, driver does not seem to update path to online. This issue appears because of the defer flag creating race condition where the same session reappears. This patch fixes this issue by indicating SCSI-ML of device lost when
qlt_free_session_done() is called from qlt_unreg_sess().

Fixes: 41dc529a4602a ("qla2xxx: Improve RSCN handling in driver")
Signed-off-by: Quinn Tran <qtran@xxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx #4.19
Signed-off-by: Himanshu Madhani <hmadhani@xxxxxxxxxxx>
Reviewed-by: Ewan D. Milne <emilne@xxxxxxxxxx>
Signed-off-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

drivers/scsi/qla2xxx/qla_target.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -981,6 +981,8 @@ void qlt_free_session_done(struct work_s

if (!IS_SW_RESV_ADDR(sess->d_id)) {
+ qla2x00_mark_device_lost(vha, sess, 0, 0);
if (sess->send_els_logo) {
qlt_port_logo_t logo;

@@ -1161,8 +1163,6 @@ void qlt_unreg_sess(struct fc_port *sess
if (sess->se_sess)

- qla2x00_mark_device_lost(vha, sess, 0, 0);
sess->disc_state = DSC_DELETE_PEND;
sess->last_rscn_gen = sess->rscn_gen;