Re: [PATCH v4 0/2] thermal: rcar_gen3_thermal: fix IRQ issues

From: Niklas Söderlund
Date: Fri May 10 2019 - 07:37:31 EST

Hi Eugeniu,

On 2019-05-10 12:42:31 +0200, Eugeniu Rosca wrote:
> Hi Niklas,
> On Wed, May 08, 2019 at 01:54:03AM +0200, Niklas Söderlund wrote:
> > Hi Jiada,
> [..]
> > I really like this series, nice work.
> >
> > Tested-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> Is there anything off-the-shelf available for testing the rcar3
> thermal driver, to avoid reinventing the wheel via

Not that I know of, unfortunately :-(

I have a private home hacked testing framework (don't we all?) based on
tcl+expect where I have two basic tests for rcar_gen3_thermal. I'm
willing to share the tests if you by chance want them, but be warned
that they are highly specialised for my needs and I'm reluctant to
publish my whole hack tool as it just a ugly hack ;-)

On a high level the tests I have are

1. thermal-load
Generates load on target and observes the temperature is increased
using the /sys/class/thermal/thermal_zone*/temp" interface. This
seems similar to the test case your reference using stress-ng.

2. thermal-cooling
Emulate the passive trip point temperatures using the
/sys/class/thermal/*/emul_temp interface and observe that the
specified cooling state is achieved.

I should add a third test to make sure IRQ fires but this is just a pet
project for me so maybe I will get around to it sometime...

If you know of anything around to test thermal drivers or if you create
something please let me know so I can add it to my tests. And let me
know if you want my hacks for inspiration for your own testing.

Niklas Söderlund