RE: [EXT] Re: [PATCH 2/2] add dts file to enable support for ls1046afrwy board.

From: Vabhav Sharma
Date: Fri May 10 2019 - 08:50:54 EST


Hi Fabio,

> -----Original Message-----
> From: Fabio Estevam <festevam@xxxxxxxxx>
> Sent: Wednesday, May 8, 2019 7:30 PM
> To: Pramod Kumar <pramod.kumar_1@xxxxxxx>
> Cc: robh+dt@xxxxxxxxxx; mark.rutland@xxxxxxx; shawnguo@xxxxxxxxxx;
> manivannan.sadhasivam@xxxxxxxxxx; Aisheng Dong
> <aisheng.dong@xxxxxxx>; Michal.Vokac@xxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Vabhav Sharma
> <vabhav.sharma@xxxxxxx>
> Subject: [EXT] Re: [PATCH 2/2] add dts file to enable support for ls1046afrwy
> board.
>
> Caution: EXT Email
>
> Hi Pramod,
>
> On Wed, May 8, 2019 at 10:56 AM Pramod Kumar
> <pramod.kumar_1@xxxxxxx> wrote:
>
> > +&fman0 {
> > + ethernet@e0000 {
>
> You have passed @e0000 without a corresponfing reg entry.
>
> This causes dtc build warnings with W=1.
>
> Please make sure you don't introduce new W=1 warnings.
ethernet node is included with fsl-ls1046-post.dtsi file and no warning is introduced.
node content can be found in arch/arm64/boot/dts/freescale/qoriq-fman3-0-1g-0.dtsi:
ethernet@e0000 {
cell-index = <0>;
compatible = "fsl,fman-memac";
reg = <0xe0000 0x1000>;
fsl,fman-ports = <&fman0_rx_0x08 &fman0_tx_0x28>;
ptp-timer = <&ptp_timer0>;
pcsphy-handle = <&pcsphy0>;
};

Regards,
Vabhav