Re: [PATCH] vsprintf: Do not break early boot with probing addresses
From: Petr Mladek
Date: Fri May 10 2019 - 10:50:45 EST
On Fri 2019-05-10 10:42:13, Petr Mladek wrote:
> The commit 3e5903eb9cff70730 ("vsprintf: Prevent crash when dereferencing
> invalid pointers") broke boot on several architectures. The common
> pattern is that probe_kernel_read() is not working during early
> boot because userspace access framework is not ready.
> It is a generic problem. We have to avoid any complex external
> functions in vsprintf() code, especially in the common path.
> They might break printk() easily and are hard to debug.
> Replace probe_kernel_read() with some simple checks for obvious
JFYI, I have sent a pull request with this patch, see