Re: Does it make sense to flush ap_list of offlined vcpu?

From: Marc Zyngier
Date: Fri May 10 2019 - 14:43:14 EST

On Thu, 09 May 2019 16:26:04 +0100,
Heyi Guo <guoheyi@xxxxxxxxxx> wrote:
> Hi folks,
> When guest OS calls PSCI CPU_OFF, the corresponding VCPU will be put
> in sleep state. But if there is still IRQ remaining in this VCPU's
> ap_list, this will block all the following triggers of this IRQ even
> to other VCPUs. Does it make sense to flush the ap_list of the VCPU
> when it is requested to be offlined? Or did I miss something?

I can't see a good reason to do so: If a vcpu gets offlined, the guest
OS has to move interrupt routed to that vcpu to another one. There is
nothing in the GIC architecture that the interrupt will be moved to
another vcpu (well, it could be done with 1:N, which is not really
virtualizable, and not advertised by KVM). That's not different from
what would happen on bare metal.



Jazz is not dead, it just smell funny.