Re: [PATCH] platform/chrome: cros_ec_spi: Always add of_match_table

From: Benson Leung
Date: Fri May 10 2019 - 17:47:54 EST

Hi Evan,

On Thu, May 09, 2019 at 11:17:50AM -0700, Evan Green wrote:
> The Chrome OS EC driver attaches to devices using the of_match_table
> even when ACPI is the underlying firmware. It does this using the
> magic PRP0001 ACPI HID, which tells ACPI to go find an OF compatible
> string under the hood and match on that.
> The cros_ec_spi driver needs to provide the of_match_table regardless
> of whether CONFIG_OF is enabled or not, since the table is used by
> ACPI for PRP0001 devices.
> Signed-off-by: Evan Green <evgreen@xxxxxxxxxxxx>

Looks good to me.
Reviewed-by: Benson Leung <bleung@xxxxxxxxxxxx>

I'll leave this to Enric to merge to our for-next.


Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
Chromium OS Project

Attachment: signature.asc
Description: PGP signature